Respect Tpay payment channel constraints when displaying available payment methods #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
lchrusciel
approved these changes
Dec 11, 2024
Comment on lines
+42
to
+44
| $validTpayChannelList = $this->orderAwareValidTpayChannelListProvider->provide($order); | ||
|
|
||
| return isset($validTpayChannelList[$tpayChannelId]); |
There was a problem hiding this comment.
would be better to pass expected tpayChannelId to the function itself, so we won't always iterate over all channels and perhaps we can optimise it event further then
Suggested change
| $validTpayChannelList = $this->orderAwareValidTpayChannelListProvider->provide($order); | |
| return isset($validTpayChannelList[$tpayChannelId]); | |
| return $this->orderAwareValidTpayChannelListProvider->provide($order, $tpayChannelId); |
but naming of class and function would need to be adjusted as well
There was a problem hiding this comment.
This OrderAwareValidTpayChannelListProvider is also used in BankListContextProvider so I cannot simply change it. However, we can extract the logic of constraint checking from OrderAwareValidTpayChannelListProvider to the separate service and then use it here.
lchrusciel
deleted the
feature/respect-constraints-in-tpay-channel-list
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.