Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-duplicate our WinUI2/3 workflow definitions with a matrix #335

Merged
merged 2 commits into from
Dec 12, 2022

Conversation

michael-hawker
Copy link
Member

@michael-hawker michael-hawker commented Dec 9, 2022

Fixes #299

Changes:

  • Uses a matrix to have a single workflow that both runs our WinUI 2 and WinUI 3 build pass
    • Only calls the one step difference for WinUI 3 on the WinUI 3 matrix pass
  • Updates XAML Styler to version compatible with .NET 6 so we remove .NET Core 3 from our build process
  • Updates GitHub Actions to latest versions
  • Updates to using latest revision of .NET 6 SDK automatically
  • Ensures test reports are only attempted to be uploaded if a test step was completed

Will move other updates to another PR, we need to update the WASM head to be off .NET 5 and maybe fix some other things, same things that are tripping up the #183 PR on linux as well.

@michael-hawker michael-hawker force-pushed the llama/workflow-improvements branch from 1010a60 to 781a952 Compare December 9, 2022 21:31
@michael-hawker
Copy link
Member Author

Hmm, so the split matrix work, but the new condition for uploading the test results failed... was a bit hard to find documentation on how those status things work.

@michael-hawker
Copy link
Member Author

Ah, found docs here I was missing: https://docs.github.com/en/actions/learn-github-actions/contexts#steps-context

I want conclusion not status.

Only upload test results if either test step was completed (i.e. if build fails and tests don't run, don't try and upload test results that don't exist)
@michael-hawker michael-hawker force-pushed the llama/workflow-improvements branch from 781a952 to 5976599 Compare December 9, 2022 23:24
@michael-hawker
Copy link
Member Author

Test reports are uploaded now as well:

image

(Need to figure out later how to better bucket since we run tests twice in each environment, but that can be a separate thing. Testspace Docs here)

Copy link
Member

@Arlodotexe Arlodotexe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very neat! I don't spot any issues, good to merge 👍

@michael-hawker michael-hawker merged commit 084e2db into main Dec 12, 2022
@delete-merged-branch delete-merged-branch bot deleted the llama/workflow-improvements branch December 12, 2022 18:44
@michael-hawker
Copy link
Member Author

Thanks @Arlodotexe, updated the branch protection rules to look for the new job names. So, just remember to rebase/update any PRs as you make changes. FYI @niels9001 as well for his open PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Workflow] Use Matrix to de-duplicate WinUI 2/3 Job
2 participants