Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #388 SizerBase Orientation Property #419

Closed

Conversation

michael-hawker
Copy link
Member

@michael-hawker michael-hawker commented Apr 15, 2023

Fixes #388

Just need to see if anything breaks in the CI due to the update to the WASDK... Otherwise, should be good to go and will help with #418's next step. 🎉

Glad to finally get this stuff resolved, this has been in the back of my mind for a while now. The new SizerBase is now above-and-beyond what we currently have in WCT. Just needs some future modern magic to discuss with @niels9001 as the final frontier (as a separate PR in the future).

@michael-hawker michael-hawker added bug 🐛 Something isn't working experiment 🧪 Used to track issues that are experiments (or their linked discussions) WinUI 💠 issue 🧪 Used for tracking an Issue/Bug/Feature of an open Experiment/Component labels Apr 15, 2023
@michael-hawker
Copy link
Member Author

michael-hawker commented Apr 15, 2023

Looks like the extensions broke in the tests with the flip or something...

Ah, it's the underlying update to the tooling sub-module with the flip to the extensions I needed to include in here.

Thinking I'll just add CommunityToolkit.WinUI back to the GlobalUsings_Tests.cs for now then?

Removes Mouse Extension from XAML Template and does in code-behind as to remove the need to set the Cursor property directly via binding
By setting the Cursor DependencyProperty we were losing our detection mechanism, now if it's set it's an explicit override, otherwise we use our logic based on Orientation property
Also, switches to new CommunityToolkit.*.Extensions Dependency vs. old copies of Tree helpers
Fixes some doc typos
Bumps version, tested on UWP, WASDK, and Uno.UI/WASM
@michael-hawker
Copy link
Member Author

Hmm, WinUI 3 failed to build do to namespace conflict... Wonder if from global using I added in tooling? Or could be the other components references to the older package, trying to change that, though Shimmer uses the animation package which has an indirect dependency... so not sure if that's still going to be trouble. This is a bit complex here with the old vs. new incompatibility with the namespace change... hmm... Would make sense that the WinUI 2 build works here as it was a completely different root to the namespace anyway.

@michael-hawker
Copy link
Member Author

Think going to have to bring other helpers over, as there's the CompositionTargetHelper and WeakEventListener used in here too... hmmm

@michael-hawker
Copy link
Member Author

Thinking about it more, we probably want to wait in using the new unified packages until more of them are setup. Otherwise, they'll start forcing folks to also use them over the 7.1.x packages when trying to use Labs components, don't think we're quite ready for that...

Will merge Niels' new style PR in first after I test on Win 10 - michael-hawker#2 - and then untease/revert back to the 7.x extension usage.

* Adding modern style

* Address feedback

* Fixing wrong state names
@michael-hawker
Copy link
Member Author

Now that CommunityToolkit/Windows#26 is merged in the new repo, we can just close this, it has the same fix as here. Should probably remove SizerBase from this repo now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working DO NOT MERGE ⚠️ experiment 🧪 Used to track issues that are experiments (or their linked discussions) issue 🧪 Used for tracking an Issue/Bug/Feature of an open Experiment/Component WinUI 💠
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SizerBase] Orientation and Cursor not set correctly
2 participants