-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incremental Loading Behavior for ItemsView #600
base: main
Are you sure you want to change the base?
Conversation
I've tried to run ApplyXamlStyling.ps1 -Main And it said no file to style. Why the workflow still fails |
@Poker-sang it's this file:
I'm not sure why the tool isn't fixing it locally for you, I wonder if we have an issue with the script when run against forks... hmm What does running It could also maybe be an issue if folks don't have their remote labeled You should just be able to run
|
MultiTarget is a custom property that indicates which target a project is designed to be built for / run on. | ||
Used to create project references, generate solution files, enable/disable TargetFrameworks, and build nuget packages. | ||
--> | ||
<MultiTarget>uwp;wasdk;wpf;wasm;linuxgtk;macos;ios;android;</MultiTarget> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is only good for WinUI 3, remove uwp
here. @Arlodotexe that should exclude it from making an entire UWP package for Uno too, eh? Then we wouldn't need the #if WINAPPSDK
conditional, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this feature only works for wasdk. But sorry that I'm not familiar with tooling
project, so don't know how exactly i should do. I hope you can help me fix this❤️thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Arlodotexe maybe something we can lend a quick hand with this after the long weekend here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The MultiTarget declarations are deployable target declarations. Uno-powered platforms support both WinUI 2/3 while UWP supports only WinUI 2 and Wasdk supports only WinUI 3.
If certain code within a component only works under certain configurations, we use compilations conditionals such as WINUI2
, WINUI3
and HAS_UNO
. The WINAPPSDK const is the legacy version of the WINUI3 const. See here for the full list.
Thanks, this works |
Also revert |
a9db5e9
to
a8059fa
Compare
Includes
NeedMoreItemTriggerBehavior
andLoadMoreItemBehavior