Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremental Loading Behavior for ItemsView #600

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Poker-sang
Copy link

Includes NeedMoreItemTriggerBehavior and LoadMoreItemBehavior

GIF2

@Arlodotexe Arlodotexe self-requested a review November 26, 2024 23:30
@Poker-sang
Copy link
Author

I've tried to run

ApplyXamlStyling.ps1 -Main

And it said no file to style.

Why the workflow still fails

@michael-hawker
Copy link
Member

@Poker-sang it's this file:

Checking: C:\a\Labs-Windows\Labs-Windows\components\Behaviors\samples\LoadMoreItemBehaviorSample.xaml
FAIL

I'm not sure why the tool isn't fixing it locally for you, I wonder if we have an issue with the script when run against forks... hmm

What does running git status and git diff origin/main your_branch_name_listed_from_git_status --name-only --diff-filter=ACM provide back?

It could also maybe be an issue if folks don't have their remote labeled origin I guess too?

You should just be able to run xstyler directly (or ensure you have the extension in VS with the search to root option enabled):

dotnet tool run xstyler -c .\settings.xamlstyler -f components\Behaviors\samples\LoadMoreItemBehaviorSample.xaml

MultiTarget is a custom property that indicates which target a project is designed to be built for / run on.
Used to create project references, generate solution files, enable/disable TargetFrameworks, and build nuget packages.
-->
<MultiTarget>uwp;wasdk;wpf;wasm;linuxgtk;macos;ios;android;</MultiTarget>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is only good for WinUI 3, remove uwp here. @Arlodotexe that should exclude it from making an entire UWP package for Uno too, eh? Then we wouldn't need the #if WINAPPSDK conditional, right?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this feature only works for wasdk. But sorry that I'm not familiar with tooling project, so don't know how exactly i should do. I hope you can help me fix this❤️thanks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Arlodotexe maybe something we can lend a quick hand with this after the long weekend here?

Copy link
Member

@Arlodotexe Arlodotexe Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MultiTarget declarations are deployable target declarations. Uno-powered platforms support both WinUI 2/3 while UWP supports only WinUI 2 and Wasdk supports only WinUI 3.

If certain code within a component only works under certain configurations, we use compilations conditionals such as WINUI2, WINUI3 and HAS_UNO. The WINAPPSDK const is the legacy version of the WINUI3 const. See here for the full list.

@Poker-sang
Copy link
Author

dotnet tool run xstyler -c .\settings.xamlstyler -f components\Behaviors\samples\LoadMoreItemBehaviorSample.xaml

Thanks, this works

@Poker-sang
Copy link
Author

Also revert tooling changes here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

3 participants