New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MarkdownTextBlock: Tables style improvements #615

Open

jcoc611-microsoft wants to merge 1 commit into CommunityToolkit:main from jcoc611-microsoft:user/juosori/Markdown_Tables_Style

jcoc611-microsoft commented Nov 29, 2024

Before:

After:

Improvements:

Margins
Single Border element for outer lines which makes it possible to have corner radius
Header background (default color is lightest accent color, configurable)


          MarkdownTextBlock: Tables style improvements

e793148

nerocui approved these changes

View reviewed changes

ShankarBUS commented Dec 7, 2024

Hi @jcoc611-microsoft

I have ported MarkdownTextBlock to Uno Platform and made some changes to it for my personal project.

https://github.com/symptum/Symptum/blob/dev/src/Symptum.UI/Markdown/TextElements/TableElement.cs

The changes I made include:

Removed of MyTableUIElement and used a plain Grid instead.
Applying the table border to the cell's grid rather than using a custom panel i.e. MyTableUIElement.
CornerRadius for each cell is calculated based on its index.
Added support for Grid Tables as well.
Rows can be colored alternatively.
Used Style instead of Brush, Thickness properties in MarkdownTheme allowing theme-awareness and more customizability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet