Make sure Popup will set the Window at the Content

[pictos]

Description of Change

.NET MAUI has the concept of Window inside some controls, when we implemented the Popup we don't care (or this concept diudn't exist yet) about it, since it should be set automagically, but this isn't the case here because Popup is an Element so we need to help the framework to set it.

Linked Issues

• Make it work for Android [BUG] Unable to display Lottie Animation within Popup #629
• Fixes [Housekeeping] Make sure Popup pass the Window from its Parent to Popup.Content  #695

From our Discord channel.

PR Checklist

• Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
• Has tests (if omitted, state reason in description)
• Has samples (if omitted, state reason in description)
• Rebased on top of main at time of PR
• Changes adhere to coding standard
• Documentation created or updated: https://github.com/MicrosoftDocs/CommunityToolkit/pull/XYZ

Additional information

[brminnick]

Hey Pedro! I just tried the reproduction sample from #629 using the NuGet Package from this PR (CommunityToolkit.Maui.1.0.0-build-674.80100.nupkg), and the iOS Lotte Animation is still frozen inside of the Popup.

Android looks good now!

iOS / macOS Animation in Popup Still Frozen	Android (Looks good!)

[pictos]

@brminnick thanks for testing on iOS, I'll give a try here, I hope the tooling works after this update

[pictos]

So... This is kinda funny, and I'm not sure if the bug is here or in .NET MAUI.
I downloaded the sample and added our .Core and .Maui projects. If I open the popup without a breaking point, the Lottie animation doesn't work, now if I set a break point and hit play it works.

So looks like a timing issue(?)

cc: @PureWeen

PopupLottie.mp4

[brminnick]

@pictos - Can we merge this since it fixes the bug on Android? As long as we keep the Bug open, we should be good right?

[pictos]

@brminnick yes, we can. I'll create a new issue related to the Window property, and link this PR to it. I'll also do a couple more changes on the PR during this week, I found some places where this can be improved.

[brminnick]

Approved bug fix for Android