Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress CA1060 #113

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Suppress CA1060 #113

merged 2 commits into from
Jul 25, 2023

Conversation

Arlodotexe
Copy link
Member

@Arlodotexe Arlodotexe commented Jul 25, 2023 •
edited
Loading

@Arlodotexe Arlodotexe mentioned this pull request Jul 25, 2023
Merged
@Arlodotexe Arlodotexe self-assigned this Jul 25, 2023
@Arlodotexe Arlodotexe added build 🔥 CI/pipeline 🔬 regression What was working is now broke bug 🐛 Something isn't working labels Jul 25, 2023
@Arlodotexe Arlodotexe marked this pull request as draft July 25, 2023 21:25
@Arlodotexe Arlodotexe marked this pull request as ready for review July 25, 2023 21:26
@michael-hawker michael-hawker mentioned this pull request Jul 25, 2023
Draft
michael-hawker
michael-hawker approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind opening a tracking issue here to switch to the new TitleBar component for long-term tracking?

CommunityToolkit.App.Shared/Controls/TitleBar/NativeMethods.cs Show resolved Hide resolved
@Arlodotexe Arlodotexe merged commit 36c23c8 into main Jul 25, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix/build-errors branch July 25, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-hawker michael-hawker michael-hawker approved these changes

@niels9001 niels9001 Awaiting requested review from niels9001

Assignees

@Arlodotexe Arlodotexe

Labels
bug 🐛 Something isn't working build 🔥 CI/pipeline 🔬 regression What was working is now broke
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arlodotexe @michael-hawker