Skip to content

Commit

Permalink
Not sure why icon isn't showing up in NuGet metadata, maybe casing as…
Browse files Browse the repository at this point in the history
… all examples show lowercase?

Also, add PackageIconUrl back as acceptable to have both for backwards compat
  • Loading branch information
michael-hawker committed Aug 16, 2023
1 parent 1d7bb48 commit bcd7115
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Directory.Build.targets
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
</PropertyGroup>

<ItemGroup Condition="$(IsPackable)">
<None Include="$(RepositoryDirectory)Icon.png" Pack="true" PackagePath="\" />
<None Include="$(RepositoryDirectory)icon.png" Pack="true" PackagePath="\" />
<None Include="$(RepositoryDirectory)License.md" Pack="true" PackagePath="\" />
<!--<None Include="$(RepositoryDirectory)ThirdPartyNotices.txt" Pack="true" PackagePath="\" />-->
</ItemGroup>
Expand Down
3 changes: 2 additions & 1 deletion Windows.Toolkit.Common.props
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
<Copyright>(c) .NET Foundation and Contributors. All rights reserved.</Copyright>
<PackageProjectUrl>https://github.com/CommunityToolkit/Windows</PackageProjectUrl>
<PackageReleaseNotes>https://github.com/CommunityToolkit/Windows/releases</PackageReleaseNotes>
<PackageIcon>Icon.png</PackageIcon>
<PackageIcon>icon.png</PackageIcon>
<PackageIconUrl>https://github.com/CommunityToolkit/Windows/blob/main/icon.png</PackageIconUrl>
<!-- TODO: Remove when closing https://github.com/CommunityToolkit/Labs-Windows/issues/256 -->
<NoWarn>$(NoWarn);NU1505;NU1504</NoWarn>
</PropertyGroup>
Expand Down
File renamed without changes

0 comments on commit bcd7115

Please sign in to comment.