Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed compositor nullreference in WinUI 3 #299

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Fixed compositor nullreference in WinUI 3 #299

merged 1 commit into from
Dec 14, 2023

Conversation

Arlodotexe
Copy link
Member

@Arlodotexe Arlodotexe commented Dec 12, 2023 •
edited
Loading

This PR closes #235, #233

PR Summary

Introduces a hotfix for a regression in the WinUI 3 package where usage of the compositor in the PipelineBuilder resulted in a NullReferenceException, caused by usage of Window.Current.Compositor instead of the WinUI 3 equivalent.

Still unable to launch the Wasdk sample app head for both the single-component Media solution and the gallery due to #212 and #169. These changes were tested by producing NuGet packages and testing in a blank Wasdk app.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • Tested code with current supported SDKs
  • New component
    • Documentation has been added
    • Sample in sample app has been added
    • Analyzers are passing for documentation and samples
    • Icon has been created (if new sample) following the Thumbnail Style Guide and templates
  • Tests for the changes have been added (if applicable)
  • Header has been added to all new source files
  • Contains NO breaking changes

@Arlodotexe Arlodotexe added the regression What was working is now broke label Dec 12, 2023
@Arlodotexe Arlodotexe self-assigned this Dec 12, 2023
michael-hawker
michael-hawker approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-hawker michael-hawker merged commit 8e4bd7a into main Dec 14, 2023
9 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/wasdk/pipelinebuilder branch December 14, 2023 17:12
@michael-hawker michael-hawker linked an issue Dec 14, 2023 that may be closed by this pull request
SurfaceLoader.LoadImageAsync always fails in WinUI 3 #233
Closed
24 tasks
@Marv51 Marv51 mentioned this pull request Jan 12, 2024
Open
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-hawker michael-hawker michael-hawker approved these changes

Assignees

@Arlodotexe Arlodotexe

Labels
regression What was working is now broke
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PipelineBuilder throw a NullReferenceException SurfaceLoader.LoadImageAsync always fails in WinUI 3
2 participants
@Arlodotexe @michael-hawker