Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Microsoft.Graphics.Win2D package reference to version 1.3.0, downgrade TFM back to 19041 #540

Merged
merged 5 commits into from
Oct 29, 2024

Conversation

Arlodotexe
Copy link
Member

This PR updates our Win2d dependency to 1.3.0. Notably, this version has a minimum TFM of net6.0-windows10.0.19041, wheras the previous 1.1.1 version we were using has a minimum TFM of net6.0-windows10.0.22621.

Since this dependency was the only reason we originally bumped our Windows App SDK TFM to 22621 (see CommunityToolkit/Tooling-Windows-Submodule#161, microsoft/Win2D#943), we can follow-up with a submodule PR to reduce our TFM back down to 19041.

@ghost1372
Copy link

Tnx @Arlodotexe
is there any date for next release?

@Arlodotexe
Copy link
Member Author

Tnx @Arlodotexe is there any date for next release?

Are you asking about the changing in this PR specifically, or for the toolkit in general?

@ghost1372
Copy link

Tnx @Arlodotexe is there any date for next release?

Are you asking about the changing in this PR specifically, or for the toolkit in general?

Toolkit.
My library is based on toolkit. (*.WinUI.Media nuget package)

@Arlodotexe
Copy link
Member Author

Arlodotexe commented Oct 25, 2024

Tnx @Arlodotexe is there any date for next release?

Are you asking about the changing in this PR specifically, or for the toolkit in general?

Toolkit. My library is based on toolkit. (*.WinUI.Media nuget package)

@ghost1372 A random PR isn't the best place to be asking, I recommend opening a new Discussion on GitHub or asking over on Discord in the future. We aim to release again before the end of the year, but our timeline can shift based on circumstances.

cc @michael-hawker, a suggestion for later-- Any time we ship, it would be good to pre-emptively open a Discussion thread for "the next release" for the community and ourselves. In the early stages, it can be used to gauge lingering needs or expectations of the community, and as we work towards that next release, we keep it updated with our general plans. That way, we can also link to it when asked. Worth consideration.

@ghost1372
Copy link

Tnx @Arlodotexe is there any date for next release?

Are you asking about the changing in this PR specifically, or for the toolkit in general?

Toolkit. My library is based on toolkit. (*.WinUI.Media nuget package)

@ghost1372 A random PR isn't the best place to be asking, I recommend opening a new Discussion on GitHub or asking over on Discord in the future. We aim to release again before the end of the year, but our timeline can shift based on circumstances.

cc @michael-hawker, a suggestion for later-- Any time we ship, it would be good to pre-emptively open a Discussion thread for "the next release" for the community and ourselves. In the early stages, it can be used to gauge lingering needs or expectations of the community, and as we work towards that next release, we keep it updated with our general plans. Worth consideration.

Thank you.
I think I misunderstood what you meant or I conveyed my meaning badly.
i am waiting for this change (19041 tfm) for CommunityToolkit.WinUI.Media package.
Therefore, I just wanted to know if this change will be published soon or not?(rc/preview release or even stable)

Arlodotexe added a commit to CommunityToolkit/Tooling-Windows-Submodule that referenced this pull request Oct 25, 2024
@Arlodotexe
Copy link
Member Author

Arlodotexe commented Oct 25, 2024

@ghost1372 I see, thank you for clarifying. We have NuGet feeds for PRs and for the main branch, see here: https://github.com/CommunityToolkit/Windows/wiki/Preview-Packages#available-preview-feeds

It's harder to give an exact date for when this would make it to stable-- we'd like to release a patch next week if we can.

@Arlodotexe
Copy link
Member Author

@Arlodotexe Arlodotexe merged commit 5ff4d4f into main Oct 29, 2024
22 of 23 checks passed
@Arlodotexe Arlodotexe deleted the win2d/update/1.3.0 branch October 29, 2024 20:54
@Arlodotexe Arlodotexe changed the title Update Microsoft.Graphics.Win2D package reference to version 1.3.0 Update Microsoft.Graphics.Win2D package reference to version 1.3.0, downgrade TFM back to 19041 Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants