-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Currency validation to TextBoxExtensions #4469
base: main
Are you sure you want to change the base?
Conversation
Adds Currency validation option for textboxes
Thanks NaftoliOst for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
|
Hi @NaftoliOst , it appears you're trying to merge this code in from the main/master branch of your forked repo. Please be aware of the rules & stipulations of submitting code into the Toolkit repo (these rules are in place due to issues we encounter when trying to merge in code from a user's main branch, into the toolkit's main branch): |
Ah, thanks for pointing that out @XAML-Knight |
Go ahead and open a new PR from one of your dev branches, and then we'll also close this one. |
Fixes #4188
Adds a currency validation option to the TextBoxExtensions
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The Decimal validation does not allow currency signs, e.g. $ or €.
What is the new behavior?
With the Currency validation type, any valid decimal with or without currency signs will be allowed.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
The code here could be refactored once The PR to add IsCurrency to StringExtensions gets merged.