Add Evaluate() method to expression nodes #4559
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
This PR contributes the Evaluate() method proposed in #4481 to evaluate the current value of any ExpresionNode at any given time (see discussion for rationale/usecases)
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently consumers of the library can't get the current or hypothetical value of a ExpressionNode without running the animation, and even if they run it is hard to guarantee that the desired result is always returned (the user needs to read the value from the composition api at the right time, which is not always easy, and I've observed cases where the values are stale and haven't been updated by the composer yet).
What is the new behavior?
This PR adds a method that evaluates it by traversing the expression tree.
This doesn't alter the current logic/behavior, and the code introduced will only be executed if the consumer calls the Evaluate() method manually.
Also added a small test that verifies that a couple expression nodes evaluate to the right result.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information