-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Refactoring NeuralNetwork class #64
Open
singraber
wants to merge
17
commits into
CompPhysVienna:master
Choose a base branch
from
singraber:automatic-weight-initialization
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[WIP] Refactoring NeuralNetwork class #64
singraber
wants to merge
17
commits into
CompPhysVienna:master
from
singraber:automatic-weight-initialization
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
singraber
commented
Sep 30, 2020
- NeuralNetwork class is the oldest part of the library and not written in modern C++
- Current implementation only allows single output neuron (not fit for structure detection).
- New class will use Eigen for all matrix operations.
- Weights and biases grouped by neuron. - Simplifies node decoupling implementation => block submatrices. - Old weight ordering available via compile flag (-DALTERNATIVE_WEIGHT_ORDERING) - Weight file output remains unchanged.
- Works now with limits instead of a group mask. - Groups are assumed to be contiguous. - Implemented rank 0 only update via new communicator.
- Tool nnp-winit also prints also gradients.
…tic-weight-initialization - Get newest NN functionality here
singraber
added
enhancement
New feature or request
core
Touches the libnnp core library
labels
Sep 30, 2020
singraber
changed the title
Refactoring NeuralNetwork class
[WIP] Refactoring NeuralNetwork class
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.