Add support for including file path for collation #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add support for including file path for collated files, this solves the problem where if you are collecting files from multiple agents, file path clashes occur. Adding the --include-file-path option will ensure that the file names are unique
Why
When harvesting evidence collected via auditree-framework's agent mode across multiple agents in a single collate run evidence gets overwritten. This means when collecting the same evidence file from multiple agents has to be achieved with a multiple runs rather than taking advantage of the feature to collect multiple files at once.
How
--include-file-path
to accepted arguments, when set to true evidence located atraw/foo/foo.json
would be collated as20191106_raw_foo_foo.json
Test
test_collate_include_file_path
)test_write_includes_file_path
)Context