-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Makefile target for pushing must-gather image #546
Add Makefile target for pushing must-gather image #546
Conversation
The must-gather target had a reference to a non-existent target called `must-gather-push`, which resulted in the following error when you attempted to build the must-gather image locally: make: *** No rule to make target 'must-gather-push', needed by 'must-gather'. Stop. This commit adds in the missing Makefile target to push the image to a specific image registry so that you can build must-gather images locally and push them to your own registry (e.g., useful for testing).
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhmdnd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
🤖 To deploy this PR, run the following command:
|
/hold for test |
Verification passed with 4.17.0-0.nightly-2024-07-07-131215 + #546
|
/unhold |
/label qe-approved |
ROSA e2e tests are failing on quota issues with AWS. Working on resolving them, but their unrelated to this patch. |
/test e2e-rosa |
3 similar comments
/test e2e-rosa |
/test e2e-rosa |
/test e2e-rosa |
Unable to recreate this locally on a ROSA cluster... Retesting to get better logs. |
Closes #159 |
/lgtm |
/test e2e-rosa Failed on image streams, which seems unrelated. |
/test e2e-rosa Ugh - another deployment timeout failure... Opening a bug so we can track this separately and find a way to deal with it. |
not related error |
Proposed a PR that attempts to update the ROSA CI version. |
/test e2e-rosa |
bef0496
into
ComplianceAsCode:master
The must-gather target had a reference to a non-existent target called
must-gather-push
, which resulted in the following error when youattempted to build the must-gather image locally:
make: *** No rule to make target 'must-gather-push', needed by 'must-gather'. Stop.
This commit adds in the missing Makefile target to push the image to a
specific image registry so that you can build must-gather images locally
and push them to your own registry (e.g., useful for testing).