Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bundle manifests #601

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

rhmdnd
Copy link

@rhmdnd rhmdnd commented Aug 20, 2024

The github action we have for making sure we update the bundle in PRs
broke, causing some changes to slip into the operator without updating
the bundle manifests.

This commit updates the bundle by running make verify-bundle then
committing the changes.

The manifests changes reflect updates we made to the operator so that it
has the necessary permissions for ingresscontrollers and
kubedeschedulers.

The github action we have for making sure we update the bundle in PRs
broke, causing some changes to slip into the operator without updating
the bundle manifests.

This commit updates the bundle by running `make verify-bundle` then
committing the changes.

The manifests changes reflect updates we made to the operator so that it
has the necessary permissions for ingresscontrollers and
kubedeschedulers.
@openshift-ci openshift-ci bot requested review from Vincent056 and xiaojiey August 20, 2024 17:45
@rhmdnd rhmdnd mentioned this pull request Aug 20, 2024
@rhmdnd rhmdnd added this to the 1.6.0 milestone Aug 20, 2024
Copy link

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:601-eebabd7c6391508a7b5e94dec65601187e87e17b

@@ -1669,7 +1678,5 @@ spec:
name: operator
- image: ghcr.io/complianceascode/k8scontent:latest
name: profile
- image: ghcr.io/complianceascode/must-gather-ocp:latest
name: must-gather
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing this in #602

Copy link

@Vincent056 Vincent056 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Aug 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd, Vincent056

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit cfc53eb into ComplianceAsCode:master Aug 20, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants