Fix Release Image Action #680
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our github action to build images for each PR for testing was failing with the following trace: Warning: Unexpected input(s) 'pr_number', valid inputs are ['message', 'file-path', 'github-token', 'reactions', 'pr-number', 'comment-tag', 'mode', 'create-if-not-exists'] I think this was causing the job to fail because it wasn't getting the PR number to leave the comment: Error: No issue/pull request in input neither in current context. This commit attempts to fix this issue by using the correct key (pr-number).
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhmdnd, Vincent056 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Adding other approval labels since this is only for our action. |
openshift-merge-bot
bot
merged commit a2b25c9
into
ComplianceAsCode:master
18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our github action to build images for each PR for testing was failing
with the following trace:
Warning: Unexpected input(s) 'pr_number', valid inputs are ['message',
'file-path', 'github-token', 'reactions', 'pr-number', 'comment-tag',
'mode', 'create-if-not-exists']
I think this was causing the job to fail because it wasn't getting the
PR number to leave the comment:
Error: No issue/pull request in input neither in current context.
This commit attempts to fix this issue by using the correct key
(pr-number).