Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new products openeuler and openeuler2203 supporting #11272

Closed
wants to merge 0 commits into from

Conversation

StevenYGui
Copy link
Contributor

Description:

  • OpenScap is a well-known security configuration baseline scanning organization in the industry. The tools provided by OpenScap provide security scanning functions for most operating systems around the world. OpenEuler also hopes to join the OpenScap family and use the powerful functions of OpenScap to complete and provide security configuration baseline scanning capabilities.

  • The openEuler community, known as the OpenAtom openEuler community, is an open source community for operating systems. The openEuler or openEuler community is incubated and operated by the Open Atomic Open Source Foundation.

  • The openEuler operating system supports application scenarios such as servers, cloud computing, edge computing, and embedded computing, and supports diversified computing. It is committed to providing a secure, stable, and easy-to-use operating system. Support OT applications and the integration of OT and ICT by providing qualitative assurance capabilities for applications.

  • Through an open community, the openEuler community works with global developers to build an open, pluralistic and inclusive software ecosystem. Incubate and support a variety of processor architectures, cover the whole scene of the word infrastructure, and promote the development of the software and hardware of the enterprise's word infrastructure and the application ecology.

  • As of June 2023, the number of openEuler community members exceeded 970 and the number of community downloads exceeded 1.45 million. With more than 14,000 developers, its living global contributors are likely to continue to promote the global ecology of openEuler.

  • openeuler2203 is a long term support version of openEuler.

Rationale:

  • This pr contains two code submissions. One is to build the openEuler-related support framework, and the other is to add common openEuler check items.

Review Hints:

  • Please review it and any feedback is my appreciate.

Copy link

openshift-ci bot commented Nov 14, 2023

Hi @StevenYGui. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Nov 14, 2023
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@marcusburghardt marcusburghardt added the New Product Issues or pull requests related to new Products. label Nov 23, 2023
@vojtapolasek vojtapolasek added this to the 0.1.72 milestone Nov 29, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Used by openshift-ci bot. label Dec 9, 2023
@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vojtapolasek vojtapolasek self-assigned this Dec 20, 2023
Copy link
Collaborator

@vojtapolasek vojtapolasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello and thank you for this contribution. I also apologize for such a long delay.
Please see my particular comments.
I have also two general questions:

  1. I see that you submit two products: openeuler and openeuler2203. I understand that the openeuler2203 is an LTS version... but what about the openeuler? Is it not versioned? Is it a rolling distribution?
  2. Could you please also modify the build_product script so that products added by this PR can be built with this script?
  3. Thank you.

@@ -0,0 +1,1812 @@
---
policy: 'Standard Benchmark for openEuler'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the policy have some resource? E.G. URL to the original document?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, i have, i will paste it latter

levels:
- id: base

controls:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it is a good idea to create reference IDs containing words as well... Are they named like that in the original security policy? I think numbers could be enough, you can put the description in the "title" tag.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, I don't quite understand your question, but you're saying it's not appropriate to use the word "base" in the id field, I can use a number, or something like "level 1", is it right?

@StevenYGui
Copy link
Contributor Author

Hello and thank you for this contribution. I also apologize for such a long delay. Please see my particular comments. I have also two general questions:

  1. I see that you submit two products: openeuler and openeuler2203. I understand that the openeuler2203 is an LTS version... but what about the openeuler? Is it not versioned? Is it a rolling distribution?
  2. Could you please also modify the build_product script so that products added by this PR can be built with this script?
  3. Thank you.

very thanks for your response, I also applogize for the delay, for your questions, my answer as below:

  1. yes, openeuler2203 is an LTS version, openeuler is a general version, just like 2009/2209 and so on, also including 2203 LTS version, acturally, it means that all openEuler versions can be checked without distinguishing specific version numbers. So, is it ok? If not, I think I can remove openeuler and keep openeuler2203.
  2. ok, I will study it and try it.

Thank you very mush.

@StevenYGui
Copy link
Contributor Author

it is closed, and I created a new PR: #11420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. needs-rebase Used by openshift-ci bot. New Product Issues or pull requests related to new Products.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants