Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMP-2455: PCI-DSS v4 Requirement 3 #11951

Merged
merged 8 commits into from
May 10, 2024
Merged

CMP-2455: PCI-DSS v4 Requirement 3 #11951

merged 8 commits into from
May 10, 2024

Conversation

yuumasato
Copy link
Member

Description:

  • 3.1, 3.2, 3.3, 3.4, 3.7 are not applicable to OCP.
  • 3.5 is partially applicable, due to Requirement 3.5.1.
  • 3.6 is inherently met.

yuumasato added 7 commits May 6, 2024 14:47
@yuumasato
CMP-2455: Requirement 3.1 isnot applicable
e786757 
These controls are documentation and process specific and there isn't a
way to enforce them using the Compliance Operator. Mark them as not
applicable.
@yuumasato
CMP-2455: Requirement 3.2 is not applicable
2d24c70 
OpenShift doesn't directly handle any account data.
@yuumasato
CMP-2455: Requirement 3.3 is not applicable
34e755a 
OpenShift doesn't directly handle Sensitive Account Data.
@yuumasato
CMP-2455: Requirement 3.4 is not applicable
1c72715 
OpenShift doesn't directly manage PAN.
@yuumasato
CMP-2455: Requirement 3.5 is partially applicable
41cacc0 
This requiremetn is about rendering stored PAN unreadable.
While OpenShift doesn't have direct access to the PAN to mask it, OCP
can configure encrypted volumes where the payment application can store
PAN.
@yuumasato
CMP-2455: Requirement 3.6 is inherently met
765304a 
The criptographic keys managed by OpenShift are securely stored by
default.
@yuumasato
CMP-2455: Requirement 3.7 is not applicable
917057d
@yuumasato yuumasato added OpenShift OpenShift product related. pci-dss labels May 6, 2024
@yuumasato yuumasato requested review from Vincent056 and rhmdnd May 6, 2024 16:45
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024 •
edited
Loading

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11951
This image was built from commit: 0983a3d

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11951

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11951 make deploy-local

@rhmdnd rhmdnd requested review from xiaojiey and BhargaviGudi May 6, 2024 18:57
rhmdnd
rhmdnd reviewed May 6, 2024
View reviewed changes
controls/pcidss_4_ocp4.yml Outdated Show resolved Hide resolved
rhmdnd
rhmdnd reviewed May 6, 2024
View reviewed changes
controls/pcidss_4_ocp4.yml Outdated Show resolved Hide resolved
rhmdnd
rhmdnd reviewed May 6, 2024
View reviewed changes
controls/pcidss_4_ocp4.yml Outdated Show resolved Hide resolved
rhmdnd
rhmdnd reviewed May 6, 2024
View reviewed changes
controls/pcidss_4_ocp4.yml Outdated Show resolved Hide resolved
rhmdnd
rhmdnd reviewed May 6, 2024
View reviewed changes
controls/pcidss_4_ocp4.yml Outdated Show resolved Hide resolved
rhmdnd
rhmdnd reviewed May 6, 2024
View reviewed changes
controls/pcidss_4_ocp4.yml Outdated Show resolved Hide resolved
rhmdnd
rhmdnd reviewed May 6, 2024
View reviewed changes
controls/pcidss_4_ocp4.yml Outdated Show resolved Hide resolved
rhmdnd
rhmdnd reviewed May 6, 2024
View reviewed changes
controls/pcidss_4_ocp4.yml Outdated Show resolved Hide resolved
rhmdnd
rhmdnd reviewed May 6, 2024
View reviewed changes
Copy link
Collaborator

@rhmdnd rhmdnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I only have some really minor suggestions inline.

@codeclimate CodeClimate
Copy link

codeclimate bot commented May 7, 2024

Code Climate has analyzed commit 0983a3d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@yuumasato
Copy link
Member Author

yuumasato commented May 7, 2024 •
edited
Loading

@rhmdnd Thank you for the review. The remarks have been addressed.

rhmdnd
rhmdnd approved these changes May 8, 2024
View reviewed changes
Copy link
Collaborator

@rhmdnd rhmdnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@xiaojiey
Copy link
Collaborator

xiaojiey commented May 8, 2024

/lgtm

@Mab879
Copy link
Member

Mab879 commented May 9, 2024

/packit retest-failed

@rhmdnd rhmdnd merged commit 8366e45 into ComplianceAsCode:master May 10, 2024
113 checks passed
@Mab879 Mab879 added this to the 0.1.74 milestone May 10, 2024
@Mab879 Mab879 added the Update Profile Issues or pull requests related to Profiles updates. label May 10, 2024
@yuumasato yuumasato deleted the pcidss_4_req_3 branch May 13, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhmdnd rhmdnd rhmdnd approved these changes

@Vincent056 Vincent056 Awaiting requested review from Vincent056

@xiaojiey xiaojiey Awaiting requested review from xiaojiey

@BhargaviGudi BhargaviGudi Awaiting requested review from BhargaviGudi

Assignees

@rhmdnd rhmdnd

Labels
OpenShift OpenShift product related. pci-dss Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Milestone
0.1.74
Development

Successfully merging this pull request may close these issues.
4 participants
@yuumasato @xiaojiey @Mab879 @rhmdnd