Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document possibility of installing ssg module with pip #12658

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Document possibility of installing ssg module with pip #12658

merged 3 commits into from
Dec 3, 2024

Conversation

vojtapolasek
Copy link
Collaborator

Description:

  • add few paragraphs to the developer guide
  • fix a typo in the heading which directly follows the modified section

Rationale:

  • improve documentation and transparency

@vojtapolasek vojtapolasek added the Documentation Update in project documentation. label Dec 2, 2024
@vojtapolasek vojtapolasek added this to the 0.1.76 milestone Dec 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

marcusburghardt
marcusburghardt requested changes Dec 2, 2024
View reviewed changes
Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some suggestions about the wording.

docs/manual/developer/05_tools_and_utilities.md Outdated Show resolved Hide resolved
docs/manual/developer/05_tools_and_utilities.md Outdated Show resolved Hide resolved
docs/manual/developer/05_tools_and_utilities.md Outdated Show resolved Hide resolved
docs/manual/developer/05_tools_and_utilities.md Outdated Show resolved Hide resolved
docs/manual/developer/05_tools_and_utilities.md Outdated Show resolved Hide resolved
@marcusburghardt marcusburghardt self-assigned this Dec 2, 2024
@vojtapolasek
Copy link
Collaborator Author

@marcusburghardt thank you, suggestions accepted.

@codeclimate CodeClimate
Copy link

codeclimate bot commented Dec 2, 2024

Code Climate has analyzed commit 5320697 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.

marcusburghardt
marcusburghardt requested changes Dec 2, 2024
View reviewed changes
Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed on minor typo in the first review. Sorry.

docs/manual/developer/05_tools_and_utilities.md Show resolved Hide resolved
@marcusburghardt
Copy link
Member

Failure in "Gate OL7" CI test is not related to this PR. It can be safely waived for this PR.

marcusburghardt
marcusburghardt approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@marcusburghardt marcusburghardt merged commit 4a525b7 into ComplianceAsCode:master Dec 3, 2024
105 of 106 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcusburghardt marcusburghardt marcusburghardt approved these changes

@jan-cerny jan-cerny Awaiting requested review from jan-cerny

Assignees

@marcusburghardt marcusburghardt

Labels
Documentation Update in project documentation.
Projects
None yet
Milestone
0.1.76
Development

Successfully merging this pull request may close these issues.
2 participants
@vojtapolasek @marcusburghardt