Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sys 1 6 a17new #12663

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

lichtblaugue
Copy link

Description:
Reopen due to rebase problems
Added notes and controls for BSI SYS.1.6 A17

Rationale:
As we have multiple customers asking for a BSI profile to be included in the compliance-operator, we are contributing a profile. To provide a better review process, the individual controle are implemented as separate PRs.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Dec 3, 2024
Copy link

openshift-ci bot commented Dec 3, 2024

Hi @lichtblaugue. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

github-actions bot commented Dec 3, 2024

Start a new ephemeral environment with changes proposed in this pull request:

ocp4 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Dec 3, 2024

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff
New content has different text for rule 'xccdf_org.ssgproject.content_rule_general_node_separation'.
--- xccdf_org.ssgproject.content_rule_general_node_separation
+++ xccdf_org.ssgproject.content_rule_general_node_separation
@@ -15,5 +15,8 @@
 [reference]:
 SYS.1.6.A3
 
+[reference]:
+SYS.1.6.A26
+
 [rationale]:
 Assigning workloads with high protection requirements to specific nodes creates and additional boundary (the node) between workloads of high protection requirements and workloads which might follow less strict requirements. An adversary which attacked a lighter protected workload now has additional obstacles for their movement towards the higher protected workloads.

New content has different text for rule 'xccdf_org.ssgproject.content_rule_scc_drop_container_capabilities'.
--- xccdf_org.ssgproject.content_rule_scc_drop_container_capabilities
+++ xccdf_org.ssgproject.content_rule_scc_drop_container_capabilities
@@ -37,6 +37,9 @@
 APP.4.4.A9
 
 [reference]:
+SYS.1.6.A17
+
+[reference]:
 2.2.1
 
 [reference]:

New content has different text for rule 'xccdf_org.ssgproject.content_rule_scc_limit_container_allowed_capabilities'.
--- xccdf_org.ssgproject.content_rule_scc_limit_container_allowed_capabilities
+++ xccdf_org.ssgproject.content_rule_scc_limit_container_allowed_capabilities
@@ -74,6 +74,9 @@
 APP.4.4.A9
 
 [reference]:
+SYS.1.6.A17
+
+[reference]:
 2.2.1
 
 [reference]:

New content has different text for rule 'xccdf_org.ssgproject.content_rule_scc_limit_host_dir_volume_plugin'.
--- xccdf_org.ssgproject.content_rule_scc_limit_host_dir_volume_plugin
+++ xccdf_org.ssgproject.content_rule_scc_limit_host_dir_volume_plugin
@@ -27,6 +27,9 @@
 APP.4.4.A9
 
 [reference]:
+SYS.1.6.A17
+
+[reference]:
 SYS.1.6.A18
 
 [reference]:

New content has different text for rule 'xccdf_org.ssgproject.content_rule_scc_limit_host_ports'.
--- xccdf_org.ssgproject.content_rule_scc_limit_host_ports
+++ xccdf_org.ssgproject.content_rule_scc_limit_host_ports
@@ -21,6 +21,9 @@
 APP.4.4.A9
 
 [reference]:
+SYS.1.6.A17
+
+[reference]:
 CNTR-OS-000660
 
 [reference]:

New content has different text for rule 'xccdf_org.ssgproject.content_rule_scc_limit_ipc_namespace'.
--- xccdf_org.ssgproject.content_rule_scc_limit_ipc_namespace
+++ xccdf_org.ssgproject.content_rule_scc_limit_ipc_namespace
@@ -39,6 +39,9 @@
 APP.4.4.A9
 
 [reference]:
+SYS.1.6.A17
+
+[reference]:
 SYS.1.6.A18
 
 [reference]:

New content has different text for rule 'xccdf_org.ssgproject.content_rule_scc_limit_net_raw_capability'.
--- xccdf_org.ssgproject.content_rule_scc_limit_net_raw_capability
+++ xccdf_org.ssgproject.content_rule_scc_limit_net_raw_capability
@@ -40,6 +40,9 @@
 APP.4.4.A9
 
 [reference]:
+SYS.1.6.A17
+
+[reference]:
 SYS.1.6.A18
 
 [reference]:

New content has different text for rule 'xccdf_org.ssgproject.content_rule_scc_limit_network_namespace'.
--- xccdf_org.ssgproject.content_rule_scc_limit_network_namespace
+++ xccdf_org.ssgproject.content_rule_scc_limit_network_namespace
@@ -39,6 +39,9 @@
 APP.4.4.A9
 
 [reference]:
+SYS.1.6.A17
+
+[reference]:
 SYS.1.6.A18
 
 [reference]:

New content has different text for rule 'xccdf_org.ssgproject.content_rule_scc_limit_privilege_escalation'.
--- xccdf_org.ssgproject.content_rule_scc_limit_privilege_escalation
+++ xccdf_org.ssgproject.content_rule_scc_limit_privilege_escalation
@@ -37,6 +37,9 @@
 APP.4.4.A9
 
 [reference]:
+SYS.1.6.A17
+
+[reference]:
 2.2.1
 
 [reference]:

New content has different text for rule 'xccdf_org.ssgproject.content_rule_scc_limit_privileged_containers'.
--- xccdf_org.ssgproject.content_rule_scc_limit_privileged_containers
+++ xccdf_org.ssgproject.content_rule_scc_limit_privileged_containers
@@ -42,6 +42,9 @@
 APP.4.4.A9
 
 [reference]:
+SYS.1.6.A17
+
+[reference]:
 SYS.1.6.A18
 
 [reference]:

New content has different text for rule 'xccdf_org.ssgproject.content_rule_scc_limit_process_id_namespace'.
--- xccdf_org.ssgproject.content_rule_scc_limit_process_id_namespace
+++ xccdf_org.ssgproject.content_rule_scc_limit_process_id_namespace
@@ -39,6 +39,9 @@
 APP.4.4.A9
 
 [reference]:
+SYS.1.6.A17
+
+[reference]:
 SYS.1.6.A18
 
 [reference]:

New content has different text for rule 'xccdf_org.ssgproject.content_rule_scc_limit_root_containers'.
--- xccdf_org.ssgproject.content_rule_scc_limit_root_containers
+++ xccdf_org.ssgproject.content_rule_scc_limit_root_containers
@@ -39,6 +39,9 @@
 APP.4.4.A9
 
 [reference]:
+SYS.1.6.A17
+
+[reference]:
 SYS.1.6.A18
 
 [reference]:

Copy link

codeclimate bot commented Dec 3, 2024

Code Climate has analyzed commit 643e183 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny added the OpenShift OpenShift product related. label Dec 4, 2024
@yuumasato
Copy link
Member

@lichtblaugue I believe this still contains unrelatd commits from another PR (CC: @sluetze)
The following commands should help you (adapt where needed):

$ git checkout master
$ git pull upstream master
$ git checkout sys-1-6-A17new
$ git rebase --onto master 1a886bd4036687080bd3049ba86af33cbf5c59a6
$ git push origin sys-1-6-A17new

@sluetze
Copy link
Contributor

sluetze commented Dec 10, 2024

@lichtblaugue I believe this still contains unrelatd commits from another PR (CC: @sluetze) The following commands should help you (adapt where needed):

$ git checkout master
$ git pull upstream master
$ git checkout sys-1-6-A17new
$ git rebase --onto master 1a886bd4036687080bd3049ba86af33cbf5c59a6
$ git push origin sys-1-6-A17new

the commits are in, because we reference the newly defined rules. So testing with this set is only possible with these commits. This PR has to be merged after the other PR.
But at least it are now the same commits and not new commits with the same content

@yuumasato yuumasato added the BSI PRs or issues for the BSI profile. label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BSI PRs or issues for the BSI profile. needs-ok-to-test Used by openshift-ci bot. OpenShift OpenShift product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants