Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu 24.04: Implement rule 5.3.3.3.3 Ensure pam_pwhistory includes use_authtok #12800

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alanmcanonical
Copy link
Contributor

Description:

  • Implement rule 5.3.3.3.3 Ensure pam_pwhistory includes use_authtok
  • Exclude line break match

Rationale:

  • Satisfies Ubuntu 24.04 CIS control 5.3.3.3.3
  • If not exclude line break, the regex pam_pwhistory\.so\s+[^#\n\r]*\buse_authtok\b.*$ will match content like
password	requisite pam_pwhistory.so remember=24 enforce_for_root try_first_pass
password	[success=1 default=ignore]	pam_unix.so obscure use_authtok try_first_pass yescrypt

@alanmcanonical alanmcanonical requested a review from a team as a code owner January 9, 2025 18:15
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jan 9, 2025
Copy link

openshift-ci bot commented Jan 9, 2025

Hi @alanmcanonical. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

github-actions bot commented Jan 9, 2025

Start a new ephemeral environment with changes proposed in this pull request:

ubuntu2404 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879
Copy link
Member

Mab879 commented Jan 10, 2025

/packit retest-failed

@dodys dodys self-assigned this Jan 10, 2025
@dodys dodys added Ubuntu Ubuntu product related. New Rule Issues or pull requests related to new Rules. Update Profile Issues or pull requests related to Profiles updates. CIS CIS Benchmark related. labels Jan 10, 2025
@dodys dodys added this to the 0.1.76 milestone Jan 10, 2025
@alanmcanonical alanmcanonical marked this pull request as draft January 15, 2025 17:43
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Jan 15, 2025
@alanmcanonical alanmcanonical marked this pull request as ready for review January 16, 2025 19:24
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Jan 16, 2025
@alanmcanonical alanmcanonical force-pushed the ubt24_53333 branch 2 times, most recently from d793b61 to 9669736 Compare January 20, 2025 13:14
Copy link

codeclimate bot commented Jan 21, 2025

Code Climate has analyzed commit cb83a2f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.9% (0.0% change).

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CIS CIS Benchmark related. needs-ok-to-test Used by openshift-ci bot. New Rule Issues or pull requests related to new Rules. Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants