-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ubuntu 24.04: Implement 2.1.21 Ensure mail transfer agent is configured for local-only mode #12818
Conversation
Hi @alanmcanonical. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This datastream diff is auto generated by the check Click here to see the full diffOVAL for rule 'xccdf_org.ssgproject.content_rule_has_nonlocal_mta' differs.
--- oval:ssg-has_nonlocal_mta:def:1
+++ oval:ssg-has_nonlocal_mta:def:1
@@ -1,2 +1,2 @@
criteria AND
-criterion oval:ssg-tst_nothing_listening_external_mta_port:tst:1
+criterion oval:ssg-tst_nothing_listening_external_mta_port_25:tst:1 |
2b56609
to
d474cb5
Compare
@alanmcanonical could you please take a look at the failed automatus test on 24.04? |
It's still due to container env has problem with systemd/dbus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
Try rebasing to fix the failing CI tests. |
5777e50
to
cef0292
Compare
Code Climate has analyzed commit cef0292 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.9% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
Description:
Rationale: