Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu 24.04: Implement 2.1.21 Ensure mail transfer agent is configured for local-only mode #12818

Merged
merged 4 commits into from
Jan 16, 2025

Conversation

alanmcanonical
Copy link
Contributor

Description:

  • Implement 2.1.21 Ensure mail transfer agent is configured for local-only mode
  • Add oval check logic for port 465 and 587

Rationale:

  • Satisfies Ubuntu 24.04 CIS control 2.1.21

@alanmcanonical alanmcanonical requested a review from a team as a code owner January 13, 2025 15:50
Copy link

openshift-ci bot commented Jan 13, 2025

Hi @alanmcanonical. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jan 13, 2025
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff
OVAL for rule 'xccdf_org.ssgproject.content_rule_has_nonlocal_mta' differs.
--- oval:ssg-has_nonlocal_mta:def:1
+++ oval:ssg-has_nonlocal_mta:def:1
@@ -1,2 +1,2 @@
 criteria AND
-criterion oval:ssg-tst_nothing_listening_external_mta_port:tst:1
+criterion oval:ssg-tst_nothing_listening_external_mta_port_25:tst:1

@dodys dodys self-assigned this Jan 14, 2025
@dodys dodys added Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates. CIS CIS Benchmark related. OVAL OVAL update. Related to the systems assessments. labels Jan 14, 2025
@dodys dodys added this to the 0.1.76 milestone Jan 14, 2025
@dodys
Copy link
Contributor

dodys commented Jan 14, 2025

@alanmcanonical could you please take a look at the failed automatus test on 24.04?

@alanmcanonical
Copy link
Contributor Author

@alanmcanonical could you please take a look at the failed automatus test on 24.04?

It's still due to container env has problem with systemd/dbus

Copy link
Contributor

@mpurg mpurg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@mpurg
Copy link
Contributor

mpurg commented Jan 15, 2025

Try rebasing to fix the failing CI tests.

Copy link

codeclimate bot commented Jan 15, 2025

Code Climate has analyzed commit cef0292 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.9% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit 653669f into ComplianceAsCode:master Jan 16, 2025
97 of 100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CIS CIS Benchmark related. needs-ok-to-test Used by openshift-ci bot. OVAL OVAL update. Related to the systems assessments. Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants