-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ubuntu 24.04: Implement 2.3.1.1 Ensure a single time synchronization daemon is in use #12823
base: master
Are you sure you want to change the base?
Conversation
Hi @alanmcanonical. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes needed
@@ -939,12 +939,11 @@ controls: | |||
levels: | |||
- l1_server | |||
- l1_workstation | |||
related_rules: | |||
rules: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This rule should not enforce any specific service.
It should only check whether the system has a single timesync service that is active,
analogous to https://github.com/ComplianceAsCode/content/pull/12822/files
In the profile we should enable only one service and disable the other
so this rule passes by default as you did here, but I think we should:
- enable timesyncd by default since it's installed by default
- move
service_chrony_enabled/service_timesyncd_disabled
to 2.3.3.3 - move
service_timesyncd_enabled/service_chronyd_disabled
to 2.3.2.2 and disable them
/packit build |
53ebf52
to
d19481d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix these issues with ctests:
Rule 'service_chronyd_disabled' must be assigned to component 'chrony', because rule uses template 'service_disabled' checking service 'chronyd' provided by package 'chrony' which is a package that already belongs to component 'chrony'.
Rule 'service_chronyd_disabled' must be assigned to component 'chrony', because it uses the package['chrony'] platform.
Rule 'service_timesyncd_disabled' must be assigned to component 'systemd', because rule uses template 'service_disabled' checking service 'systemd-timesyncd' provided by package 'systemd-timesyncd' which is a package that already belongs to component 'systemd'.
Rule 'service_timesyncd_disabled' must be assigned to component 'systemd', because it uses the package['systemd-timesyncd'] platform.
Implement rule ntp_single_service_active
ea2f341
to
7937e33
Compare
Added, thanks |
7937e33
to
65c57df
Compare
Complete rules 2.3.2.2 and 2.3.3.3
65c57df
to
563a18f
Compare
Code Climate has analyzed commit 563a18f and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.9% (0.0% change). View more on Code Climate. |
Description:
Rationale: