Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sssd service enabled test scenarios #12862

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

ggbecker
Copy link
Member

Description:

  • The 'files' directive is now deprecated and there the 'proxy' directive
    that can be used as a replacement. Preserve the old test scenario so it should still work on older RHEL
    versions for example. RHEL9 should work with the new style but kept the
    same for integrity.

@ggbecker ggbecker added bugfix Fixes to reported bugs. RHEL10 Red Hat Enterprise Linux 10 product related. labels Jan 20, 2025
@ggbecker ggbecker added this to the 0.1.76 milestone Jan 20, 2025
@ggbecker ggbecker marked this pull request as draft January 20, 2025 15:52
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Jan 20, 2025
The 'files' directive is now deprecated and there the 'proxy' directive
that can be used as a replacement.

Preserve the old test scenario so it should still work on older RHEL
versions for example. RHEL9 should work with the new style but kept the
same for integrity.
@ggbecker ggbecker force-pushed the fix-sssd-service-enabled branch from c9ed83c to 90c5316 Compare January 20, 2025 15:54
Copy link

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff
New content has different text for rule 'xccdf_org.ssgproject.content_rule_service_sssd_enabled'.
--- xccdf_org.ssgproject.content_rule_service_sssd_enabled
+++ xccdf_org.ssgproject.content_rule_service_sssd_enabled
@@ -9,7 +9,7 @@
 $ sudo systemctl enable sssd.service
 
 [warning]:
-The service requires a valid sssd configuration. If the configuration is not present, the service will fail to start and consequently this rule will will be reported as failing. The configuration shipped in your distribution package might not be sufficient. Manual modification of configuration files might be required.
+The service requires a valid sssd configuration. If the configuration is not present, the service will fail to start and consequently this rule will be reported as failing. The configuration shipped in your distribution package might not be sufficient. Manual modification of configuration files might be required.
 
 [reference]:
 1

@ggbecker ggbecker marked this pull request as ready for review January 20, 2025 15:56
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Jan 20, 2025
@ggbecker
Copy link
Member Author

ggbecker commented Jan 20, 2025

RHEL10

tests/automatus.py rule --libvirt qemu:///system rhel10 --debug --datastream /home/ggasparb/workspace/github/content/build/ssg-rhel10-ds.xml --remediate-using bash service_sssd_enabled
Setting console output to log level INFO
INFO - The base image option has not been specified, choosing libvirt-based test environment.
INFO - Logging into /home/ggasparb/workspace/github/content/logs/rule-custom-2025-01-20-1653/test_suite.log
INFO - xccdf_org.ssgproject.content_rule_service_sssd_enabled
INFO - Script service_disabled.fail.sh using profile (all) OK
INFO - Script service_enabled.pass.sh using profile (all) OK

@ggbecker
Copy link
Member Author

ggbecker commented Jan 20, 2025

RHEL9:

tests/automatus.py rule --libvirt qemu:///system rhel9 --debug --datastream build/ssg-rhel9-ds.xml --remediate-using bash service_sssd_enabled 
Setting console output to log level INFO
INFO - The base image option has not been specified, choosing libvirt-based test environment.
INFO - Logging into /home/ggasparb/workspace/github/content/logs/rule-custom-2025-01-20-1654/test_suite.log
INFO - xccdf_org.ssgproject.content_rule_service_sssd_enabled
INFO - Script service_disabled.fail.sh using profile (all) OK
INFO - Script service_enabled.pass.sh using profile (all) OK

Copy link

codeclimate bot commented Jan 20, 2025

Code Climate has analyzed commit 90c5316 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.9% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 self-assigned this Jan 20, 2025
@Mab879 Mab879 merged commit 0776086 into ComplianceAsCode:master Jan 21, 2025
103 of 109 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes to reported bugs. RHEL10 Red Hat Enterprise Linux 10 product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants