CMP-3630: Filter route protection rule by edge termination #13968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The routes_protected_by_tls rule will check for any routes that are allowing insecure termination policies. In other words, recommending that users setup their routes to require secure communication, or redirect from http to https. However, some routes might be using passthrough, where the route passes that off to the application to handle. Let's exclude passthrough cases from this rule since that's handled by the application, and not the route.
|
/test |
|
@rhmdnd: The Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test 4.18-e2e-aws-ocp4-cis |
|
/test 4.18-e2e-aws-ocp4-pci-dss |
|
@rhmdnd: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Looks like this passed by default: |
I guess the operators reported in the issue are not available by default? |
Correct - it doesn't look like it. I created some routes locally when testing, but we could add one to the e2e testing if we want to test that it catches invalid routes by default, although we don't typically put the cluster in a bad state for testing. Instead, we just harden things that fail out-of-the-box. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The routes_protected_by_tls rule will check for any routes that are
allowing insecure termination policies. In other words, recommending
that users setup their routes to require secure communication, or
redirect from http to https. However, some routes might be using
passthrough, where the route passes that off to the application to
handle. Let's exclude passthrough cases from this rule since that's
handled by the application, and not the route.