CMP-3540: Remove SDN proxy kubeconfig assertions from 4.17+ assertion files #13987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… files OpenShift uses OVN Kubernetes on 4.17, and the SDN rules are not applicable in those versions such that they're not run in profiles that use them. This commit removes the assertions that expect them to be there on those versions.
|
/test |
|
@rhmdnd: The Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test 4.18-e2e-aws-ocp4-cis |
|
@rhmdnd: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
yuumasato
requested changes
Oct 7, 2025
There was a problem hiding this comment.
@rhmdnd So if I understand correctly, the rules are still evaluated, but result in NOT-APPLICABLE.
After ocp4e2e refactor we started looping through ComplianceCheckResutls, and rules resulting in NOT-APPLICABLE don't generate a CCR. Is that correct?
If so it probably makes sense to remove all rules resulting in NOT-APPLICABLE.
| ocp4-cis-file-groupowner-proxy-kubeconfig: | ||
| default_result: NOT-APPLICABLE | ||
| result_after_remediation: NOT-APPLICABLE | ||
| ocp4-cis-file-owner-proxy-kubeconfig: |
There was a problem hiding this comment.
Remove ocp4-cis-file-owner-proxy-kubeconfig too.
| ocp4-cis-etcd-peer-key-file: | ||
| default_result: PASS | ||
| result_after_remediation: PASS | ||
| ocp4-cis-file-groupowner-proxy-kubeconfig: |
There was a problem hiding this comment.
Remove ocp4-cis-file-groupowner-proxy-kubeconfig too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenShift uses OVN Kubernetes on 4.17, and the SDN rules are not
applicable in those versions such that they're not run in profiles that
use them. This commit removes the assertions that expect them to be
there on those versions.