Skip to content

Fix linux disable network sniffer ansible syntax for non-standard interfaces #14076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2025
+2 −2
Merged

Fix linux disable network sniffer ansible syntax for non-standard interfaces #14076

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75f983a
Fix linux disable network sniffer ansible syntax for sub interfaces
Hazerre Oct 31, 2025
e0df617
fix network_sniffer_disabled task when statement being string
Hazerre Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions linux_os/guide/system/network/network_sniffer_disabled/ansible/shared.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

- name: "{{{ rule_title }}} - Disable promiscuous mode"
ansible.builtin.command:
cmd: ip link set dev {{ item.split(':')[1] }} multicast off promisc off
cmd: ip link set dev {{ (item.split(':')[1] | trim).split('@')[0] }} multicast off promisc off
Copy link
Collaborator

@jan-cerny jan-cerny Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your change looks good to me. However, I have noticed a suspicious thing that exists below on line 16.

network_interfaces.stdout_lines is defined and "item.split(':') | length == 3"

I think that the double quotes shouldn't be there because they represent a string literal, not a jinja expression.

I think it should be:

network_interfaces.stdout_lines is defined and item.split(':') | length == 3

Can you take a look into this?

Copy link
Contributor Author

@Hazerre Hazerre Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I'm not sure why it was like that before or how it was passing tests. Added another commit to resolve that.

loop: "{{ network_interfaces.stdout_lines }}"
when: network_interfaces.stdout_lines is defined and "item.split(':') | length == 3"
when: network_interfaces.stdout_lines is defined and item.split(':') | length == 3

Loading