Make the ssg module to pass mypy #14077
Open
+115
−167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
str is no longer ANSSI only
As Python 3.0 is has been moved. See: https://docs.python.org/3.0/library/urllib.parse.html#urllib.parse.quote
pipes is a Python 2 thing. See https://docs.python.org/3/library/shlex.html#shlex.quote
Also more type safe
Nothing we can do
These seem to be cursed. For now, we will just ignore them. Maybe some day I will solve typing puzzle.
Made mypy mad, it is bad form, and outside of the try catch doesn't really do anything on in this case.
Mab879
requested review from
ggbecker,
jan-cerny,
marcusburghardt,
matusmarhefka and
vojtapolasek
as code owners
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Mab879
force-pushed
the
improve_mypy_and_python
branch
from
34d3848 to
13707e2
Compare
Mab879
force-pushed
the
improve_mypy_and_python
branch
from
9439b29 to
70fafa9
Compare
|
/packit retest-failed |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
This PR is big enough, once this PR is merged I will open a new PR to add more types. |
|
@Mab879: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I might split this PR up, mainly creating this PR to see how much of the CI I fail.
Rationale:
Allow us to catch bugs easier.
Review Hints:
Check that mypy is ran for the
ssgpackage in CI