Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add test and fix miss BeginBlock #523

Merged
merged 6 commits into from
May 30, 2024
Merged

fix: add test and fix miss BeginBlock #523

merged 6 commits into from
May 30, 2024

Conversation

hoank101
Copy link
Collaborator

No description provided.

github-advanced-security[bot]
github-advanced-security bot found potential problems May 27, 2024
View reviewed changes
x/mint/abci.go
// fetch stored minter & params
minter := k.GetMinter(ctx)
params := k.GetParams(ctx)
minter := k.GetMinter(sdkCtx)

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods Warning

path flow from Begin/EndBlock to a panic call
x/mint/module.go Dismissed Show dismissed Hide dismissed
x/ratelimit/module.go
// AppModuleSimulation functions
// BeginBlock implements the AppModule interface
func (am AppModule) BeginBlock(ctx context.Context) error {
return am.keeper.BeginBlocker(ctx)

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods Warning

path flow from Begin/EndBlock to a panic call
@RustNinja
Copy link
Collaborator

Thank you @hoank101 for this changes.
there a lot of interchain tests that cover important logic. thank you so much.
Could you please add interchain tests for

  • staking epoch feature. (that voting power is updating not immediately once some stake/unstake their native tokens but voting power should be update each 30 mins (based on storage configuration in staking middleware module))
  • ibc/pfm custom fees still working after migration to sdk50.

@RustNinja RustNinja self-requested a review May 28, 2024 14:25
@hoank101
Copy link
Collaborator Author

Thank you @hoank101 for this changes. there a lot of interchain tests that cover important logic. thank you so much. Could you please add interchain tests for

  • staking epoch feature. (that voting power is updating not immediately once some stake/unstake their native tokens but voting power should be update each 30 mins (based on storage configuration in staking middleware module))
  • ibc/pfm custom fees still working after migration to sdk50.

yeah, tomorrow I will add

@kkast kkast merged commit 46975cd into develop2 May 30, 2024
18 of 19 checks passed
@kkast kkast deleted the hoa/add-test branch May 30, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkast kkast kkast approved these changes

@RustNinja RustNinja Awaiting requested review from RustNinja

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hoank101 @RustNinja @kkast