Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ta bug #253

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Fix Ta bug #253

merged 2 commits into from
Feb 12, 2025

Conversation

finsberg
Copy link
Member

@finsberg finsberg commented Feb 11, 2025

Fix bug in strong coupling.

Previously we have been solving

$$ 0 = \nabla \cdot P = \nabla \cdot \frac{d(\psi + Ta(\lambda)(I_{4f} - I))}{dF} $$

Now we are instead solving

$$ 0 = \nabla \cdot P = \nabla \cdot ( \frac{d \psi}{dF} + Ta(\lambda)\frac{d (I_{4f} - I)}{dF}) $$

Adopted from https://github.com/ComputationalPhysiology/simcardems2

@finsberg finsberg requested a review from cdaversin February 11, 2025 15:44
@finsberg finsberg merged commit 334558f into main Feb 12, 2025
4 checks passed
@finsberg finsberg deleted the fix-Ta-bug branch February 28, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant