Update the pmacc tuple and its use in the binning plugin #5264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikbuibui
force-pushed
the
tuple_update
branch
from
cd01f68 to
7574c6d
Compare
ikbuibui
force-pushed
the
tuple_update
branch
from
7574c6d to
3c3c6c1
Compare
psychocoderHPC
previously approved these changes
Feb 4, 2025
|
@ikbuibui please rebase agains tthe current dev branch |
ikbuibui
force-pushed
the
tuple_update
branch
3 times, most recently
from
39f79b2 to
250e9fc
Compare
psychocoderHPC
previously approved these changes
Feb 4, 2025
ikbuibui
force-pushed
the
tuple_update
branch
4 times, most recently
from
3774555 to
104b757
Compare
|
This pr should be rebased/merged after #5266 is in the dev branch to ensure we not break anything. Currently the CI is only running g++-CUDA tests. |
ikbuibui
force-pushed
the
tuple_update
branch
5 times, most recently
from
30e7a84 to
e91d763
Compare
ikbuibui
force-pushed
the
tuple_update
branch
2 times, most recently
from
170f885 to
01d0e62
Compare
… enumerated apply
ikbuibui
force-pushed
the
tuple_update
branch
from
01d0e62 to
bf2c805
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a tuple size implementation to the pmacc tuple
Use pmacc tuple on the host side as well
Add a new function
applyEnumeratedwhich passes pairs of(index ,tuple)to the callable argumentFix forwarding of arguments in
binning::applyandtupleMap