Major Project Slack Bot #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jabbate19
requested changes
Sep 8, 2022
jabbate19
requested changes
Sep 8, 2022
| @@ -65,7 +70,7 @@ def submit_major_project(user_dict=None): | |||
| return jsonify({"success": False}), 400 | |||
| project = MajorProject(user_dict['username'], name, description) | |||
|
|
|||
| send_slack_ping({"text":f"<!subteam^S5XENJJAH> {user_dict['username']} submitted their major project, *{name}*!"}) | |||
| send_slack_ping({"text":f"<!subteam^S5XENJJAH> {context_processors.get_member_name(user_dict['username'])} *{user_dict['username']}* submitted their major project, *{name}*!"}) | |||
There was a problem hiding this comment.
You shouldn't need to specify context_processors if you did what you did on line 1... should be able to just do get_member_name
There was a problem hiding this comment.
Also nit on the formatting, I think it would be easier to read if the username was in parentheses, not boldened. We know people by name first and the username is extra into
Merged
jabbate19
requested changes
Sep 8, 2022
|
Fixes #359 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.