Fixed github auth stuff so it actually works

[BigSpaceships]

crying in whatever the auth system is for github apps

also I'll fix the merge conflicts but I can't figure out how to do it without making a pr

[BigSpaceships]

This needs the same OAuth app creds as before and then GITHUB_APP_ID is the id of a github app and GITHUB_APP_PRIVATE_KEY is a private key of the app.

The app needs perms read write org members and should be installed on the csh org

[BigSpaceships]

Noticing one of the linting things messed up a lot of the formatting I could revert that I'm not entirely sure how that happened since the previous commits were being linted and passing before?

[costowell]

Looks wonderful, just a nitpick

[mxmeinhold]

I'm confused why yapf took such a substantial change to everything, given that it hadn't complained about mom/dev before. Part of the reason I chose it was that it's pep8 style, and wouldn't make substantial revisions. If you give me a ping in the morning, I'd be happy to give a review

[BigSpaceships]

@mxmeinhold yeah I am not quite sure apparently it's maybe not deterministic?
(also here's your ping)

[mxmeinhold]

Ah I see, in 1f019f8, things were moved to paratheses, at which point the formatter won't maintain the newlines

-_SLACK_AUTH_URI = 'https://slack.com/oauth/authorize' \
-        + '?scope=identity.basic' \
-        + '&client_id=%s' \
-        + '&state=%s' \
-        + '&redirect_uri=https://eac.csh.rit.edu/slack/return'
+_SLACK_AUTH_URI = (
+    "https://slack.com/oauth/authorize"
+    + "?scope=identity.basic"
+    + "&client_id=%s"
+    + "&state=%s"
+    + "&redirect_uri=https://eac.csh.rit.edu/slack/return"
+)```

[mxmeinhold]

Alright I think I got it figured out, sent you an email

[BigSpaceships]

okay there we go I fixed it hopefully and the diff is better I think I just ran the wrong linting commands when I was attempting to get it to pass because I didn't see the stuff in the readme

[BigSpaceships]

also ngl I didn't see your email until now but I think looking at the patches we did the same thing 🤷

[BigSpaceships]

sorry I can't figure out how to request a review so @mxmeinhold

[mxmeinhold]

take a glance at if you need to bump csh ldap, otherwise looking good

[mxmeinhold]

I'd bump to 2.5.1 for this fix ComputerScienceHouse/csh_ldap#39

[mxmeinhold]

@BigSpaceships I'm fine with this getting merged, did you get someone to add the token config in okd?

[BigSpaceships]

@costowell Can you add a not dev private key and client id to okd? The same perms the old one should work fine lmk if you need help with what is what and what we did last time

[costowell]

Looks epic, I have created a non-dev Github app.