Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sponsored transaction enabled auction #32

Merged
merged 51 commits into from
Jan 11, 2024
Merged

Sponsored transaction enabled auction #32

merged 51 commits into from
Jan 11, 2024

Conversation

DOBEN
Copy link
Member

@DOBEN DOBEN commented Nov 29, 2023 •
edited
Loading

Purpose

The front end and back end part of sponsored transaction enabled auction

Concordium/concordium-rust-smart-contracts#367

Changes

Add front end and back end part of sponsored transaction enabled auction

@DOBEN DOBEN force-pushed the sponsored-tx-enabled-auction-contract branch from 1bb512b to 0db9ee7 Compare November 29, 2023 12:41
@DOBEN DOBEN changed the title WIP: Initial sponsored transaction enabled auction Sponsored transaction enabled auction Dec 7, 2023
@DOBEN DOBEN mentioned this pull request Dec 7, 2023
Closed
8 tasks
abizjak
abizjak reviewed Dec 8, 2023
View reviewed changes
sponsoredTransactionsAuction/Dockerfile Outdated Show resolved Hide resolved
sponsoredTransactionsAuction/Dockerfile Outdated Show resolved Hide resolved
sponsoredTransactionsAuction/Dockerfile Outdated Show resolved Hide resolved
sponsoredTransactionsAuction/Dockerfile Outdated Show resolved Hide resolved
sponsoredTransactionsAuction/Dockerfile Outdated Show resolved Hide resolved
sponsoredTransactionsAuction/frontend/src/writing_to_blockchain.ts Outdated Show resolved Hide resolved
sponsoredTransactionsAuction/frontend/src/writing_to_blockchain.ts Outdated Show resolved Hide resolved
sponsoredTransactionsAuction/frontend/src/components/MintTokens.tsx Outdated Show resolved Hide resolved
sponsoredTransactionsAuction/backend/src/main.rs Outdated Show resolved Hide resolved
sponsoredTransactionsAuction/backend/src/main.rs Outdated Show resolved Hide resolved
@abizjak
Copy link
Contributor

abizjak commented Dec 8, 2023

@DOBEN There is another point I forgot to mention.

For new backends we should be using axum instead of warp. I would really like it if you changed it, but I understand it is annoying to do this now so I won't insist on it.

soerenbf
soerenbf reviewed Dec 11, 2023
View reviewed changes
Copy link
Contributor

@soerenbf soerenbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the comments below, I think it would make sense to use our @concordium/ccd-js-gen package to generate a client to use for interacting with the contract instead of reading/writing-to-blockchain files. It isn't ideal for use with the wallet libraries yet, but it provides everything you need for reading from the contract, and for writing it provides you the JSON version of the parameter types.

.gitignore Outdated Show resolved Hide resolved
sponsoredTransactionsAuction/frontend/.eslintrc.js Outdated Show resolved Hide resolved
sponsoredTransactionsAuction/frontend/.yarnrc.yml Show resolved Hide resolved
sponsoredTransactionsAuction/frontend/.eslintrc.js Outdated Show resolved Hide resolved
sponsoredTransactionsAuction/backend/src/main.rs Outdated Show resolved Hide resolved
sponsoredTransactionsAuction/frontend/src/SponsoredTransactions.tsx Outdated Show resolved Hide resolved
sponsoredTransactionsAuction/frontend/src/components/AddItemToAuction.tsx Outdated Show resolved Hide resolved
sponsoredTransactionsAuction/frontend/src/components/AddItemToAuction.tsx Outdated Show resolved Hide resolved
sponsoredTransactionsAuction/frontend/src/components/Bid.tsx Outdated Show resolved Hide resolved
sponsoredTransactionsAuction/frontend/tsconfig.json Outdated Show resolved Hide resolved
@DOBEN DOBEN force-pushed the sponsored-tx-enabled-auction-contract branch from 3c6f6c5 to 1e28544 Compare January 3, 2024 18:54
@DOBEN DOBEN force-pushed the sponsored-tx-enabled-auction-contract branch from 7085d41 to 424b12e Compare January 5, 2024 15:41
@DOBEN DOBEN requested review from soerenbf and abizjak January 5, 2024 15:41
soerenbf
soerenbf approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@soerenbf soerenbf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that this is something for your PR in particular, but it would be nice with CI in place for checking that the frontends conform to lint/formatting rules (since it is a repository for dApp examples).

Other than that it worked fine when I tested it 😄

sponsoredTransactionsAuction/frontend/.eslintrc.cjs Outdated Show resolved Hide resolved
abizjak
abizjak approved these changes Jan 10, 2024
View reviewed changes
sponsoredTransactionsAuction/Dockerfile Outdated Show resolved Hide resolved
sponsoredTransactionsAuction/backend/Cargo.toml Outdated Show resolved Hide resolved
sponsoredTransactionsAuction/backend/README.md Outdated Show resolved Hide resolved
sponsoredTransactionsAuction/backend/README.md Outdated Show resolved Hide resolved
sponsoredTransactionsAuction/backend/src/types.rs Outdated Show resolved Hide resolved
sponsoredTransactionsAuction/backend/src/main.rs Outdated Show resolved Hide resolved
sponsoredTransactionsAuction/backend/src/main.rs Outdated Show resolved Hide resolved
sponsoredTransactionsAuction/backend/src/main.rs Outdated Show resolved Hide resolved
sponsoredTransactionsAuction/backend/src/main.rs Outdated Show resolved Hide resolved
sponsoredTransactionsAuction/backend/src/main.rs Show resolved Hide resolved
@DOBEN
Copy link
Member Author

DOBEN commented Jan 11, 2024 •
edited
Loading

Not that this is something for your PR in particular, but it would be nice with CI in place for checking that the frontends conform to lint/formatting rules (since it is a repository for dApp examples).

Other than that it worked fine when I tested it 😄

Agree, there is an issue already for adding CI pipelines (linting/testing) for all dApp examples. I would leave it to that issue and not start adding CI pipelines in this PR so.
#3

@DOBEN DOBEN mentioned this pull request Jan 11, 2024
Open
4 tasks
@DOBEN DOBEN force-pushed the sponsored-tx-enabled-auction-contract branch from a3fc621 to 5965919 Compare January 11, 2024 11:09
@DOBEN DOBEN force-pushed the sponsored-tx-enabled-auction-contract branch from 5965919 to 0d83292 Compare January 11, 2024 12:49
@DOBEN DOBEN merged commit 24541f2 into main Jan 11, 2024
6 checks passed
@DOBEN DOBEN deleted the sponsored-tx-enabled-auction-contract branch January 11, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abizjak abizjak abizjak approved these changes

@soerenbf soerenbf soerenbf approved these changes

@shjortConcordium shjortConcordium Awaiting requested review from shjortConcordium

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DOBEN @abizjak @soerenbf