Skip to content

Commit

Permalink
JAV-323 Support company ID attributes (#337)
Browse files Browse the repository at this point in the history
* Add company ID attribute types

* Update Android build platform to 29

So it matches the one in concordium-base wallet lib.

* Update version 7.2.0-SNAPSHOT

* Gitignore Idea folder

* Update concordium-base to 38cf687
  • Loading branch information
Radiokot authored Aug 1, 2024
1 parent 0ac11b7 commit f4e37e0
Show file tree
Hide file tree
Showing 11 changed files with 24 additions and 13 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ jobs:
run: |
${ANDROID_SDK_ROOT}/cmdline-tools/latest/bin/sdkmanager \
--sdk_root=$ANDROID_SDK_ROOT \
"platform-tools" "platforms;android-27" "build-tools;27.0.3"
"platform-tools" "platforms;android-29" "build-tools;29.0.2"
- name: Checkout
uses: actions/checkout@v2
with:
Expand All @@ -114,4 +114,4 @@ jobs:
- name: Initialize root project
run: mvn install -N
- name: Build android sdk
run: cd concordium-android-sdk && mvn --batch-mode --update-snapshots install
run: cd concordium-android-sdk && mvn --batch-mode --update-snapshots install
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ jobs:
run: |
${ANDROID_SDK_ROOT}/cmdline-tools/latest/bin/sdkmanager \
--sdk_root=$ANDROID_SDK_ROOT \
"platform-tools" "platforms;android-27" "build-tools;27.0.3"
"platform-tools" "platforms;android-29" "build-tools;29.0.2"
# Setup rust
- name: Setup Rust
uses: actions-rs/toolchain@v1
Expand Down Expand Up @@ -130,7 +130,7 @@ jobs:
run: |
${ANDROID_SDK_ROOT}/cmdline-tools/latest/bin/sdkmanager \
--sdk_root=$ANDROID_SDK_ROOT \
"platform-tools" "platforms;android-27" "build-tools;27.0.3"
"platform-tools" "platforms;android-29" "build-tools;29.0.2"
- name: Setup JDK 8
uses: actions/setup-java@v4
with:
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@
*.iml
.flattened-pom.xml
pom.xml.versionsBackup
.idea/
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## Unreleased
- Added `MessageSigningDigest` class to generate digests for message signing
- Added support for company identity attributes

## 7.1.0
- Removed unnecessary `amount` parameter from `InvokeInstanceRequest`.
Expand Down
4 changes: 2 additions & 2 deletions concordium-android-sdk/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<parent>
<groupId>com.concordium.sdk</groupId>
<artifactId>concordium-sdk-base</artifactId>
<version>7.1.0-SNAPSHOT</version>
<version>7.2.0-SNAPSHOT</version>
</parent>

<artifactId>concordium-android-sdk</artifactId>
Expand Down Expand Up @@ -265,7 +265,7 @@
<debuggable>true</debuggable>
</manifest>
<sdk>
<platform>27</platform>
<platform>29</platform>
</sdk>
<nativeLibrariesDirectory>${project.basedir}/native</nativeLibrariesDirectory>
</configuration>
Expand Down
2 changes: 1 addition & 1 deletion concordium-base
Submodule concordium-base updated 106 files
2 changes: 1 addition & 1 deletion concordium-sdk-examples/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
<dependency>
<groupId>com.concordium.sdk</groupId>
<artifactId>concordium-sdk</artifactId>
<version>7.1.0-SNAPSHOT</version>
<version>7.2.0-SNAPSHOT</version>
<scope>compile</scope>
</dependency>
<dependency>
Expand Down
2 changes: 1 addition & 1 deletion concordium-sdk/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<parent>
<groupId>com.concordium.sdk</groupId>
<artifactId>concordium-sdk-base</artifactId>
<version>7.1.0-SNAPSHOT</version>
<version>7.2.0-SNAPSHOT</version>
</parent>

<groupId>com.concordium.sdk</groupId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,16 @@ public enum AttributeType {
@JsonProperty("taxIdNo")
TAX_ID_NO,
@JsonProperty("lei")
LEI;
LEI,
@JsonProperty("legalName")
LEGAL_NAME,
@JsonProperty("legalCountry")
LEGAL_COUNTRY,
@JsonProperty("businessNumber")
BUSINESS_NUMBER,
@JsonProperty("registrationAuth")
REGISTRATION_AUTH,
;

public static AttributeType fromJSON(String jsonStr) throws JsonMappingException, JsonProcessingException {
return JsonMapper.INSTANCE.readValue(String.format("\"%s\"", jsonStr), AttributeType.class);
Expand Down
4 changes: 2 additions & 2 deletions crypto-jni/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

<groupId>com.concordium.sdk</groupId>
<artifactId>concordium-sdk-base</artifactId>
<version>7.1.0-SNAPSHOT</version>
<version>7.2.0-SNAPSHOT</version>
<packaging>pom</packaging>

<url>https://github.com/Concordium/concordium-java-sdk</url>
Expand Down

0 comments on commit f4e37e0

Please sign in to comment.