Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend pool info #277

Merged
merged 6 commits into from
Nov 1, 2023
Merged

Extend pool info #277

merged 6 commits into from
Nov 1, 2023

Conversation

magnusbechwind
Copy link
Contributor

@magnusbechwind magnusbechwind commented Oct 25, 2023 •
edited
Loading

Purpose

Support the added field in PoolInfoResponsecontaining commission rates for the current reward period.

Changes

Added a field to CurrentPaydayStatus containing the commission rates.
Updated the test to reflect the changes.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@magnusbechwind magnusbechwind marked this pull request as ready for review October 25, 2023 09:01
MilkywayPirate
MilkywayPirate reviewed Oct 25, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
MilkywayPirate
MilkywayPirate approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@MilkywayPirate MilkywayPirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@magnusbechwind
Merge branch 'main' into extendPoolInfo
415d729 
# Conflicts:
#	CHANGELOG.md
@magnusbechwind magnusbechwind merged commit 0c8975e into main Nov 1, 2023
1 check passed
@magnusbechwind magnusbechwind deleted the extendPoolInfo branch November 1, 2023 12:37
@magnusbechwind magnusbechwind mentioned this pull request Nov 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MilkywayPirate MilkywayPirate MilkywayPirate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magnusbechwind @MilkywayPirate