Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android sdk #292

Merged
merged 15 commits into from
Jan 16, 2024
Merged

Android sdk #292

merged 15 commits into from
Jan 16, 2024

Conversation

shjortConcordium
Copy link
Contributor

Purpose

Add support for android / building a AAR artifact.

Changes

  • Added commands to add android targets and build the native lib for those targets in the make file.
  • Added new maven module to build AAR artifact for android.
  • Added android specific behaviour in NativeResolver.
  • Moved package version into a parent module.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@shjortConcordium shjortConcordium requested a review from orhoj January 3, 2024 12:27
orhoj
orhoj suggested changes Jan 4, 2024
View reviewed changes
.github/workflows/release.yml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
concordium-android-sdk/AndroidManifest.xml Outdated Show resolved Hide resolved
concordium-sdk/src/main/java/com/concordium/sdk/crypto/NativeResolver.java Show resolved Hide resolved
MilkywayPirate
MilkywayPirate reviewed Jan 5, 2024
View reviewed changes
Copy link
Contributor

@MilkywayPirate MilkywayPirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, GJ.

I have a few comments/questions that I would like to be adressed/answered before merge.

.github/workflows/release.yml Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
concordium-sdk/pom.xml Show resolved Hide resolved
MilkywayPirate
MilkywayPirate approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@MilkywayPirate MilkywayPirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! GJ

@shjortConcordium shjortConcordium merged commit 31c2c29 into main Jan 16, 2024
2 checks passed
@shjortConcordium shjortConcordium deleted the android-sdk branch January 16, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orhoj orhoj orhoj approved these changes

@MilkywayPirate MilkywayPirate MilkywayPirate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shjortConcordium @MilkywayPirate @orhoj