Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix expiry type #301

Merged
merged 5 commits into from
Jan 25, 2024
Merged

Fix expiry type #301

merged 5 commits into from
Jan 25, 2024

Conversation

orhoj
Copy link
Contributor

@orhoj orhoj commented Jan 24, 2024

Purpose

  • Use the Expiry type instead of TransactionExpiry for credential deployment transactions to align with account transactions.

Changes

  • Fix an issue where the library for example wallet was not placed correctly.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@orhoj orhoj marked this pull request as ready for review January 24, 2024 12:01
@orhoj orhoj merged commit b96fb70 into main Jan 25, 2024
2 checks passed
@orhoj orhoj deleted the fix-expiry-type branch January 25, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shjortConcordium shjortConcordium shjortConcordium approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orhoj @shjortConcordium