Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy to maven central #303

Merged
merged 34 commits into from
Feb 2, 2024
Merged

Deploy to maven central #303

merged 34 commits into from
Feb 2, 2024

Conversation

shjortConcordium
Copy link
Contributor

@shjortConcordium shjortConcordium commented Jan 25, 2024 •
edited
Loading

Purpose

Deploy to maven central as part of the release action.

Changes

  • Refactoring + added the maven central steps to release flow.
  • Added plugins and profiles to poms to facilitate deployment.
  • Added info in parent pom
  • Bumped versions to 6.1.0

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@shjortConcordium shjortConcordium force-pushed the deploy-android branch 2 times, most recently from 7b5b3fb to f1408df Compare January 25, 2024 09:19
@shjortConcordium shjortConcordium changed the title Deploy android Deploy to maven central Feb 1, 2024
@shjortConcordium shjortConcordium requested review from orhoj and MilkywayPirate and removed request for orhoj February 1, 2024 16:15
MilkywayPirate
MilkywayPirate reviewed Feb 2, 2024
View reviewed changes
Copy link
Contributor

@MilkywayPirate MilkywayPirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Minor questions and comments.

concordium-android-sdk/.gitignore Show resolved Hide resolved
concordium-sdk/pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
@shjortConcordium shjortConcordium merged commit 7488808 into main Feb 2, 2024
2 checks passed
@shjortConcordium shjortConcordium deleted the deploy-android branch February 2, 2024 12:53
This was referenced Feb 2, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orhoj orhoj orhoj approved these changes

@MilkywayPirate MilkywayPirate MilkywayPirate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shjortConcordium @MilkywayPirate @orhoj @soer8647