-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cis2 #304
Merged
Merged
Cis2 #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MilkywayPirate
requested review from
abizjak,
magnusbechwind and
shjortConcordium
February 6, 2024 13:46
abizjak
suggested changes
Feb 7, 2024
concordium-sdk/src/main/java/com/concordium/sdk/cis2/Cis2Client.java
Outdated
Show resolved
Hide resolved
concordium-sdk/src/main/java/com/concordium/sdk/cis2/Cis2Client.java
Outdated
Show resolved
Hide resolved
concordium-sdk/src/main/java/com/concordium/sdk/cis2/Cis2Client.java
Outdated
Show resolved
Hide resolved
concordium-sdk/src/main/java/com/concordium/sdk/cis2/Cis2Client.java
Outdated
Show resolved
Hide resolved
concordium-sdk/src/main/java/com/concordium/sdk/cis2/Cis2Client.java
Outdated
Show resolved
Hide resolved
concordium-sdk/src/main/java/com/concordium/sdk/cis2/TokenId.java
Outdated
Show resolved
Hide resolved
concordium-sdk/src/main/java/com/concordium/sdk/cis2/TokenId.java
Outdated
Show resolved
Hide resolved
concordium-sdk/src/main/java/com/concordium/sdk/cis2/events/Cis2Event.java
Show resolved
Hide resolved
concordium-sdk/src/main/java/com/concordium/sdk/cis2/events/Cis2EventWithMetadata.java
Outdated
Show resolved
Hide resolved
concordium-sdk/src/main/java/com/concordium/sdk/cis2/events/MintEvent.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it could make sense to have examples for some of the CIS-2 client methods, like we do for in the JS SDK?
https://github.com/Concordium/concordium-node-sdk-js/tree/main/examples/nodejs/cis2
concordium-sdk/src/main/java/com/concordium/sdk/transactions/ReceiveName.java
Show resolved
Hide resolved
concordium-sdk/src/main/java/com/concordium/sdk/transactions/UpdateContract.java
Show resolved
Hide resolved
concordium-sdk/src/main/java/com/concordium/sdk/types/ContractAddress.java
Show resolved
Hide resolved
...k/src/main/java/com/concordium/sdk/responses/blockitemsummary/AccountTransactionDetails.java
Show resolved
Hide resolved
concordium-sdk/src/main/java/com/concordium/sdk/types/AbstractAddress.java
Outdated
Show resolved
Hide resolved
abizjak
approved these changes
Feb 13, 2024
concordium-sdk/src/main/java/com/concordium/sdk/cis2/Cis2Error.java
Outdated
Show resolved
Hide resolved
concordium-sdk/src/main/java/com/concordium/sdk/cis2/TokenAmount.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Aleš Bizjak <[email protected]>
Co-authored-by: Aleš Bizjak <[email protected]>
….java Co-authored-by: Aleš Bizjak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Address #216 by introducing a
Cis2Client
for interfacing with CIS2 compliant smart contracts.Changes
Cis2Client
for interfacing with a CIS2 compliant smart contractAccountTransactionDetails
object.Checklist
hard-to-understand areas.