-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use concordium-base wallet library #320
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soerenbf
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with a nice chunk of code removed 🥇
As mentioned in one of the comments, it would be good if we could add documentation in the form of jsdoc to at least everything new we export 😄
…nto use-concordium-base-wallet-library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Use
wallet_library
from concordium-base to create identity requests, identity recover requests and for creating unsigned credentials.This also comes with the addition of two new methods for creating these:
Changes
rust-bindings
and depend onwallet_library
in concordium-base instead.createIdRequestWithKeysV1
,createIdentityRecoveryRequestWithKeys
andcreateUnsignedCredentialWithKeysV1
) fromrust-bindings
. Updated SDK accordingly to provide access to this functionality.createUnsignedCredentialV1
to use the seed instead of being the function that takes the secret key material directly.example/wallet
to use identity creation and unsigned credential creation that does not provide the whole seed to the library.Checklist
hard-to-understand areas.