Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use concordium-base wallet library #320

Merged
merged 20 commits into from
Jan 11, 2024
Merged

Conversation

orhoj
Copy link
Contributor

@orhoj orhoj commented Dec 19, 2023

Purpose

Use wallet_library from concordium-base to create identity requests, identity recover requests and for creating unsigned credentials.

This also comes with the addition of two new methods for creating these:

  • Creating an identity request without providing the whole seed,
  • Creating an identity recovery request without providing the whole seed.

Changes

  • Remove custom implementations from rust-bindings and depend on wallet_library in concordium-base instead.
  • Expose three new WASM entrypoints (createIdRequestWithKeysV1, createIdentityRecoveryRequestWithKeys and createUnsignedCredentialWithKeysV1) from rust-bindings. Updated SDK accordingly to provide access to this functionality.
  • Change WASM entrypoint createUnsignedCredentialV1 to use the seed instead of being the function that takes the secret key material directly.
  • Update example/wallet to use identity creation and unsigned credential creation that does not provide the whole seed to the library.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG. I accept the above linked CLA.

@orhoj orhoj marked this pull request as ready for review December 20, 2023 10:53
@orhoj orhoj requested a review from soerenbf December 20, 2023 13:04
@orhoj orhoj requested a review from bisgardo January 2, 2024 10:12
Copy link
Collaborator

@soerenbf soerenbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with a nice chunk of code removed 🥇

As mentioned in one of the comments, it would be good if we could add documentation in the form of jsdoc to at least everything new we export 😄

packages/rust-bindings/CHANGELOG.md Outdated Show resolved Hide resolved
packages/sdk/src/wasm/identity.ts Show resolved Hide resolved
packages/sdk/src/wasm/identity.ts Outdated Show resolved Hide resolved
@orhoj orhoj merged commit 4628ea7 into main Jan 11, 2024
11 checks passed
@orhoj orhoj deleted the use-concordium-base-wallet-library branch January 11, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants