Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ccd-js-gen: Flag for generating @ts-nocheck #323

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Conversation

limemloh
Copy link
Collaborator

@limemloh limemloh commented Jan 9, 2024

Purpose

Closes #313.
Provide flag for generating // @ts-nocheck.

Changes

  • Introduce a new option in both CLI and library for enabling this.
  • Extend some details in the changelog.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@limemloh limemloh requested a review from DOBEN January 9, 2024 08:13
@DOBEN
Copy link
Member

DOBEN commented Jan 9, 2024

I still get the error:

'__nominal' is declared but its value is never read.
private __nominal = true;

It seems the // @ts-nocheck needs to be really at the top of the file. Currently, it is not at the top.

Screenshot from 2024-01-09 09-38-51

packages/ccd-js-gen/src/cli.ts Outdated Show resolved Hide resolved
packages/ccd-js-gen/src/lib.ts Outdated Show resolved Hide resolved
packages/ccd-js-gen/src/cli.ts Outdated Show resolved Hide resolved
@limemloh limemloh requested a review from DOBEN January 9, 2024 09:35
@limemloh limemloh merged commit c2a9f4c into main Jan 9, 2024
11 checks passed
@abizjak abizjak deleted the ccd-js-gen-ts-nocheck branch January 9, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ccd-js-gen] Make it possible to skip checking generated files
2 participants