Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the rust version used in pipeline #381

Merged
merged 7 commits into from
Aug 7, 2024
Merged

Conversation

limemloh
Copy link
Collaborator

@limemloh limemloh commented Aug 7, 2024

Purpose

Fix issue causing the rust-bindings wasm module to throw runtime error: unreachable.

Changes

  • Use a fixed Rust toolchain version everywhere in the pipeline. This will fix an issue in the deployment, since the wasm-pack version 0.12.1 seems incompatible with the rust version actually used by the CI (which was 1.79 by accident).
  • Add unit test catching the above issue, when we update the rust version sometime in the future.
  • Correct path for caching of concordium-contracts-common workspace.
  • Remove unused type AttributeRandomness.

@limemloh limemloh requested a review from soerenbf August 7, 2024 11:01
Copy link
Collaborator

@soerenbf soerenbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 😄

@limemloh limemloh merged commit 98a2736 into main Aug 7, 2024
10 checks passed
@limemloh limemloh deleted the pipeline-fix-rust-version branch August 7, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants