Add fallback for available balance to be compatible with node version 6 #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soerenbf
force-pushed
the
node-6-compat
branch
from
c18b4b4
to
ed70159
Compare
limemloh
approved these changes
Sep 6, 2024
| const accountAmount = CcdAmount.fromProto(unwrap(acc.amount)); | ||
|
|
||
| let accountAvailableBalance: CcdAmount.Type; | ||
| if (acc.availableBalance !== undefined) { |
There was a problem hiding this comment.
Suggestion:
It would be good to add a comment on why this can be undefined, since the current gRPC makes it looks like it cannot, so we should add this context.
It should include what node versions this will actually be relevant for
There was a problem hiding this comment.
Good suggestion, will add this
soerenbf
force-pushed
the
node-6-compat
branch
from
ed70159
to
c4c54fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
AccountInfo.accountAvailableBalanceChecklist
hard-to-understand areas.