Add legal country for set and not-set membership proofs #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DOBEN
force-pushed
the
fix-set-membership-proof-for-legal-country
branch
from
e2b0fa4
to
32ba954
Compare
Ivan-Mahda
approved these changes
Sep 12, 2024
soerenbf
approved these changes
Sep 12, 2024
|
It seems all checks passed? When will the chrome ext be released for testnet? |
|
Dear @nhs-it, We are working on the browser wallet release that includes |
|
Dear @DOBEN - any update on the browser wallet using web-sdk 8.1.0 - on testnet? |
|
@nhs-it |
|
@nhs-it The new browser wallet Version 1.7.1 has been released. This wallet includes company ZK proofs now since the web-sdk has been updated. https://developer.concordium.software/en/mainnet/net/release-notes/release-notes-lp.html#bw |
|
Great! thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The browser wallet calls the
verifySetStatementfunction to exclude all the attributes not allowed for these types of proofs. TheLegalCountryattribute (from company IDs) has been added recently. Propagating this addition to the SDK.Related: Concordium/concordium-browser-wallet#484
Related: Concordium/concordium-base#542
Changes