Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Haskell stackage snapshot to LTS-22.9 #1114

Merged
merged 18 commits into from
Feb 6, 2024
Merged

Update Haskell stackage snapshot to LTS-22.9 #1114

merged 18 commits into from
Feb 6, 2024

Conversation

td202
Copy link
Contributor

@td202 td202 commented Jan 11, 2024

Purpose

Closes #1093

This upgrades the stack resolver to LTS-22.9, and the corresponding GHC version to 9.6.4.

Changes

  • Resolver is update to lts-22.9 in stack.yaml files.
  • The package proto-lens-setup and its dependencies proto-lens-protoc and ghc-source-gen are not included in the LTS distribution, so specific versions from Hackage are pinned in the stack.yaml files.
  • The -fPIC compiler option is disabled on Windows, as it results in the compiled code crashing due to access violations. Position independent code is not used on Windows in any case. There is an open GHC issue that seems to be related: https://gitlab.haskell.org/ghc/ghc/-/issues/24016
  • TypeOperators is added to the default extensions. In future, this will be needed for using ~, and currently will generate a warning if not enabled.
  • Some imports are changed due to changes in library structure (notably, Control.Monad is explicitly imported, whereas it previously was implicitly imported through other monad modules).
  • Some code changes make types more explicit, e.g. in (type-changing record updates)[https://gitlab.haskell.org/ghc/ghc/-/wikis/migration/9.6#type-changing-record-updates-involving-type-families].
  • In some cases where redundant constraint warnings were suppressed, this has been lifted. In other cases, the reason why they are suppressed is updated.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

Copy link
Contributor

@abizjak abizjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had some problems with installing ghc 9.6.3 which were "fixed" by restarting the build a few times.

Not very reassuring, but seems to work.

concordium-consensus/package.yaml Show resolved Hide resolved
@td202 td202 changed the title Update Haskell stackage snapshot to LTS-22.5 Update Haskell stackage snapshot to LTS-22.9 Feb 5, 2024
@td202 td202 merged commit 825b59f into main Feb 6, 2024
3 checks passed
@td202 td202 deleted the lts-22.5 branch February 6, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade GHC
4 participants