-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Primed for suspension #1293
Primed for suspension #1293
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a few changes.
concordium-consensus/src/Concordium/Scheduler/TreeStateEnvironment.hs
Outdated
Show resolved
Hide resolved
Co-authored-by: Thomas Dinsdale-Young <[email protected]>
Co-authored-by: Thomas Dinsdale-Young <[email protected]>
cc68cc4
to
46c2dcc
Compare
46c2dcc
to
63378e0
Compare
63378e0
to
af93309
Compare
9c9c419
to
cf99cb0
Compare
cf99cb0
to
e04d097
Compare
concordium-consensus/src/Concordium/GlobalState/Persistent/BlockState.hs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me (modulo existing comments)! 💪
td202 is on holiday, all requested changes have been discussed/implemented.
Purpose
This is the implementation of automatic suspension for validators that missed too many rounds. Suspension happens at snapshot, while priming new validators for suspension at payday.
We compute the to be suspended validators during epoch transition at snapshot before we prime validators for future suspension. This is to avoid priming and then immediately suspending validators when the length of the payday is one.
Changes
bsoPrimeValidators
andbsoSuspendValidators
computeBakerStakesAndCapital
to ignore newly suspended validators at snapshotChecklist
hard-to-understand areas.
CLA acceptance
_Remove if not applicable.
By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0
link: https://developers.concordium.com/CLAs/Contributor-License-Agreement-v1.0.pdf
I accept the above linked CLA.