Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProcessorConfig improvements and more #219

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

limemloh
Copy link
Contributor

@limemloh limemloh commented Dec 20, 2024

Purpose

Bug fixes and improvements from implementing CCDscan indexer

Changes

  • Add constructor TokenAddress::new for CIS2 type TokenAddress.
  • ProcessorConfig now requires the future for signaling graceful shutdown is marked Send effectively marking ProcessorConfig as Send. This is a minor breaking change, but expected to be the case for most if not all use cases.
  • Introduce ProcessorConfig::process_event_stream which is equivalent to ProcessorConfig::process_events but the events argument is generalized to be some implementation of Stream.
  • Fix issue in ProcessorConfig::process_event_stream and ProcessorConfig::process_events where it did not check the stop signal while retrying, preventing a graceful shutdown.
  • Change behavior of TraverseConfig::traverse to continuously start up new Indexer::on_finalized tasks up to max_parallel as the output channel takes the results of prior tasks.
    The prior behavior was to start preparing max_parallel tasks, then wait for everything to be consumed before starting another round of max_parallel tasks.
  • Introduce RewardsOverview::common_reward_data for getting the common reward data across RewardsOverview version 0 and version 1.

@limemloh limemloh marked this pull request as ready for review January 8, 2025 11:14
@limemloh limemloh changed the title ProcessorConfig improvements ProcessorConfig improvements and more Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants