Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation smart contract aggregate #93

Merged
38 commits merged into from
Sep 5, 2023

Conversation

ghost
Copy link

@ghost ghost commented Aug 22, 2023

Purpose

To implement Smart Contract features data needs to be fetched and stored as events. These can then later be mapped to endpoints and visualised in the UI.

Design has been written at: https://concordium.atlassian.net/wiki/spaces/EN/pages/1190199324/Design

Task:

Changes

Added a Smart Contract aggregate which can map data either from node or existing data. Existing data are used by a job, which is run prior to the job which continuously fetched data from node.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@ghost ghost requested review from shjortConcordium and orhoj August 22, 2023 13:34
@ali-concordium
Copy link

We should aim to split the PRs into smaller chunks. In example one PR related to the schema changes only, and a second introducing the aggregate and so forth. Otherwise I can be a bit hard to understand and go through every line, to make sure nothing was missed.

Copy link

@ali-concordium ali-concordium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional code comments. Feel free to skip whatever you don't agree with.

@ghost ghost merged commit 79ae099 into main Sep 5, 2023
1 check passed
@ghost ghost deleted the cbw-1248/implementation-smart-contract-aggregate branch September 5, 2023 11:02
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant